Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: set max-warnings allowed in the CI to 0 #6489

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Jan 29, 2024

closes #6488

@clarani clarani requested a review from a team as a code owner January 29, 2024 14:59
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9301dba) 27.88% compared to head (af0d463) 27.88%.
Report is 6 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6489      +/-   ##
============================================
- Coverage     27.88%   27.88%   -0.01%     
  Complexity     2167     2167              
============================================
  Files          1007     1008       +1     
  Lines        126932   126959      +27     
  Branches       2585     2586       +1     
============================================
+ Hits          35398    35399       +1     
- Misses        90039    90064      +25     
- Partials       1495     1496       +1     
Flag Coverage Δ
core 78.56% <ø> (ø)
editoast 75.50% <ø> (+<0.01%) ⬆️
front 8.65% <ø> (-0.01%) ⬇️
gateway 2.50% <ø> (ø)
railjson_generator 87.44% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni-6488-set-max-warning-to-0 branch from 213ccc8 to 11c99f1 Compare January 29, 2024 15:02
Copy link
Contributor

@anisometropie anisometropie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely

@clarani clarani force-pushed the cni-6488-set-max-warning-to-0 branch from 11c99f1 to af0d463 Compare January 30, 2024 09:43
@clarani clarani added this pull request to the merge queue Jan 30, 2024
Merged via the queue into dev with commit 2a2abf9 Jan 30, 2024
21 checks passed
@clarani clarani deleted the cni-6488-set-max-warning-to-0 branch January 30, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: set max-warning authorized to 0 in the CI
4 participants