Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix osm import handle invalid speed values #6607

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

flomonster
Copy link
Contributor

I found a speed limit of 0 when trying to import the German OSM infrastructure in Railjson.

@flomonster flomonster requested a review from a team as a code owner February 9, 2024 11:21
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be24aee) 27.89% compared to head (98bbf8c) 27.89%.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6607      +/-   ##
============================================
- Coverage     27.89%   27.89%   -0.01%     
  Complexity     2177     2177              
============================================
  Files          1040     1040              
  Lines        127633   127633              
  Branches       2610     2610              
============================================
- Hits          35609    35604       -5     
- Misses        90493    90498       +5     
  Partials       1531     1531              
Flag Coverage Δ
core 79.37% <ø> (ø)
editoast 75.37% <100.00%> (-0.03%) ⬇️
front 8.41% <ø> (ø)
gateway 2.50% <ø> (ø)
railjson_generator 87.25% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Tristramg Tristramg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@flomonster flomonster added this pull request to the merge queue Feb 9, 2024
Merged via the queue into dev with commit c4ec440 Feb 9, 2024
22 checks passed
@flomonster flomonster deleted the fam/import-osm-check-speeds branch February 9, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants