-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timetable import command for train schedule v2 #6754
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #6754 +/- ##
============================================
- Coverage 28.34% 28.34% -0.01%
Complexity 2177 2177
============================================
Files 1047 1047
Lines 129444 129450 +6
Branches 2576 2576
============================================
- Hits 36691 36688 -3
- Misses 91265 91274 +9
Partials 1488 1488
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f0b60b9
to
0cad0d3
Compare
d815eeb
to
a052108
Compare
a052108
to
3405e32
Compare
3405e32
to
7df202d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. I made some minor request changes.
Can you also add a unit test that:
- Imports the
simple_array.json
- Delete the created timetable.
640aa52
to
de5de78
Compare
d2557c1
to
b8ab1b1
Compare
617ce7e
to
cd11893
Compare
cd11893
to
8ae74d9
Compare
Added a test fixture
editoast/src/tests/train_schedules/simple_array.json
Tested with timetable creation and timetable specification.
Closes #6737