Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timetable import command for train schedule v2 #6754

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

ElysaSrc
Copy link
Contributor

@ElysaSrc ElysaSrc commented Feb 27, 2024

Added a test fixture editoast/src/tests/train_schedules/simple_array.json

Tested with timetable creation and timetable specification.

Closes #6737

@ElysaSrc ElysaSrc self-assigned this Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 28.34%. Comparing base (6d33ff6) to head (8ae74d9).
Report is 3 commits behind head on dev.

Files Patch % Lines
editoast/src/client/mod.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6754      +/-   ##
============================================
- Coverage     28.34%   28.34%   -0.01%     
  Complexity     2177     2177              
============================================
  Files          1047     1047              
  Lines        129444   129450       +6     
  Branches       2576     2576              
============================================
- Hits          36691    36688       -3     
- Misses        91265    91274       +9     
  Partials       1488     1488              
Flag Coverage Δ
core 79.39% <ø> (ø)
editoast 75.88% <50.00%> (-0.04%) ⬇️
front 8.61% <ø> (ø)
gateway 2.50% <ø> (ø)
railjson_generator 87.26% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from yci/create-model-v2-timetable to dev February 27, 2024 17:38
@ElysaSrc ElysaSrc force-pushed the ev/import-trains-cli branch 2 times, most recently from d815eeb to a052108 Compare February 28, 2024 09:50
@ElysaSrc ElysaSrc marked this pull request as ready for review February 28, 2024 09:51
@ElysaSrc ElysaSrc requested a review from a team as a code owner February 28, 2024 09:51
@flomonster flomonster changed the title editoast: add train import command for train schedule v2 Add timetable import command for train schedule v2 Feb 28, 2024
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I made some minor request changes.

Can you also add a unit test that:

  • Imports the simple_array.json
  • Delete the created timetable.

editoast/src/client/mod.rs Outdated Show resolved Hide resolved
editoast/src/client/mod.rs Outdated Show resolved Hide resolved
editoast/src/main.rs Outdated Show resolved Hide resolved
editoast/src/main.rs Outdated Show resolved Hide resolved
@ElysaSrc ElysaSrc force-pushed the ev/import-trains-cli branch 7 times, most recently from 640aa52 to de5de78 Compare February 29, 2024 09:19
@ElysaSrc ElysaSrc force-pushed the ev/import-trains-cli branch 2 times, most recently from d2557c1 to b8ab1b1 Compare February 29, 2024 10:34
editoast/src/main.rs Outdated Show resolved Hide resolved
@ElysaSrc ElysaSrc force-pushed the ev/import-trains-cli branch 2 times, most recently from 617ce7e to cd11893 Compare February 29, 2024 17:19
@ElysaSrc ElysaSrc added this pull request to the merge queue Feb 29, 2024
Merged via the queue into dev with commit d45ca39 Feb 29, 2024
22 checks passed
@ElysaSrc ElysaSrc deleted the ev/import-trains-cli branch February 29, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS2: Add editoast CLI to import a timetable
2 participants