Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: fix train position projection #6798

Merged
merged 1 commit into from
Mar 5, 2024
Merged

editoast: fix train position projection #6798

merged 1 commit into from
Mar 5, 2024

Conversation

ElysaSrc
Copy link
Contributor

@ElysaSrc ElysaSrc commented Mar 5, 2024

Skip simulated points at intersection boundary.
Closes #6717

@ElysaSrc ElysaSrc requested a review from a team as a code owner March 5, 2024 17:40
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 👏

Copy link
Contributor

@Khoyo Khoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.28%. Comparing base (e25652d) to head (aeed2aa).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #6798   +/-   ##
=========================================
  Coverage     28.27%   28.28%           
- Complexity     2177     2179    +2     
=========================================
  Files          1048     1048           
  Lines        129976   129987   +11     
  Branches       2577     2578    +1     
=========================================
+ Hits          36756    36764    +8     
- Misses        91731    91734    +3     
  Partials       1489     1489           
Flag Coverage Δ
core 79.44% <ø> (+0.04%) ⬆️
editoast 75.86% <100.00%> (-0.03%) ⬇️
front 8.62% <ø> (ø)
gateway 2.50% <ø> (ø)
railjson_generator 87.26% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Skip simulated points at intersection boundary

Co-authored-by: Florian Amsallem <florian.amsallem@epita.fr>
Co-authored-by: Younes Khoudli <younes.khoudli@epita.fr>
@ElysaSrc ElysaSrc added this pull request to the merge queue Mar 5, 2024
Merged via the queue into dev with commit b9785b7 Mar 5, 2024
22 checks passed
@ElysaSrc ElysaSrc deleted the ev/fix-crash-stdcm branch March 5, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STDCM fails to find a solution in scenarios where an obvious one exists.
3 participants