Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kt-fast-collections: fix array init performance bug #6805

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

multun
Copy link
Contributor

@multun multun commented Mar 6, 2024

Before

2024-03-06_12-03-1709723817

After

2024-03-06_12-03-1709725297

@multun multun requested a review from a team as a code owner March 6, 2024 11:40
@multun multun requested a review from Erashin March 6, 2024 11:40
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.26%. Comparing base (b1f8892) to head (c6ac2c1).

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #6805   +/-   ##
=========================================
  Coverage     28.26%   28.26%           
  Complexity     2179     2179           
=========================================
  Files          1049     1049           
  Lines        130290   130290           
  Branches       2578     2578           
=========================================
  Hits          36820    36820           
  Misses        91981    91981           
  Partials       1489     1489           
Flag Coverage Δ
core 79.44% <ø> (ø)
editoast 75.14% <ø> (ø)
front 8.62% <ø> (ø)
gateway 2.50% <ø> (ø)
railjson_generator 87.26% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eckter eckter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm it makes a difference 👍

@multun multun added this pull request to the merge queue Mar 6, 2024
Merged via the queue into dev with commit 1f27b88 Mar 6, 2024
22 checks passed
@multun multun deleted the fast-array-init branch March 6, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants