Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: fix openapi and typo #6842

Merged
merged 1 commit into from
Mar 12, 2024
Merged

editoast: fix openapi and typo #6842

merged 1 commit into from
Mar 12, 2024

Conversation

younesschrifi
Copy link
Contributor

No description provided.

@younesschrifi younesschrifi requested a review from a team as a code owner March 11, 2024 14:55
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 94.17989% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 28.45%. Comparing base (02cebc2) to head (ce8b7a4).
Report is 1 commits behind head on dev.

Files Patch % Lines
front/src/common/api/osrdEditoastApi.ts 95.53% 8 Missing ⚠️
...rc/applications/editor/tools/routeEdition/utils.ts 33.33% 2 Missing ⚠️
editoast/src/schema/utils/duration.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6842      +/-   ##
============================================
+ Coverage     28.36%   28.45%   +0.08%     
  Complexity     2179     2179              
============================================
  Files          1055     1055              
  Lines        131011   131182     +171     
  Branches       2602     2602              
============================================
+ Hits          37167    37326     +159     
- Misses        92331    92343      +12     
  Partials       1513     1513              
Flag Coverage Δ
core 79.44% <ø> (ø)
editoast 74.94% <85.71%> (-0.02%) ⬇️
front 8.89% <94.50%> (+0.15%) ⬆️
gateway 2.49% <ø> (ø)
railjson_generator 87.26% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@younesschrifi younesschrifi force-pushed the yci/fix-path-properties branch 2 times, most recently from 42bc649 to 63a06e9 Compare March 11, 2024 16:20
@younesschrifi younesschrifi requested a review from a team as a code owner March 11, 2024 16:20
@younesschrifi younesschrifi force-pushed the yci/fix-path-properties branch 2 times, most recently from 2622ba6 to 8c72f39 Compare March 11, 2024 16:41
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

editoast/src/views/v2/path/pathfinding.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Tguisnet Tguisnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@younesschrifi younesschrifi added this pull request to the merge queue Mar 12, 2024
Merged via the queue into dev with commit f2d9e03 Mar 12, 2024
22 checks passed
@younesschrifi younesschrifi deleted the yci/fix-path-properties branch March 12, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants