-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: remove serde default from project and study #6949
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #6949 +/- ##
============================================
- Coverage 28.95% 28.94% -0.01%
Complexity 2244 2244
============================================
Files 1070 1070
Lines 132528 132528
Branches 2713 2713
============================================
- Hits 38371 38365 -6
- Misses 92580 92586 +6
Partials 1577 1577
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
03c75ac
to
5126409
Compare
8a4548b
to
6775dfd
Compare
6f34c1a
to
e937be7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to Adapt OpenAPI and tests, otherwise it looks good to me for the editoast part.
e937be7
to
2e47538
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
9eb0f13
to
36fdd62
Compare
36fdd62
to
43a6acc
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #6949 +/- ##
============================================
- Coverage 28.19% 28.18% -0.01%
Complexity 2273 2273
============================================
Files 1128 1128
Lines 139439 139439
Branches 2804 2804
============================================
- Hits 39309 39302 -7
- Misses 98498 98505 +7
Partials 1632 1632
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
43a6acc
to
3fa6a1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement (and bug fix) 🎉
3fa6a1e
to
ecef139
Compare
ecef139
to
b050e4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
close #6773