Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yci/add editoast simulation summary endpoint #7119

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

younesschrifi
Copy link
Contributor

@younesschrifi younesschrifi commented Apr 5, 2024

close #6857

@younesschrifi younesschrifi requested review from a team as code owners April 5, 2024 15:22
@younesschrifi younesschrifi force-pushed the yci/add-editoast-simulation-summary-endpoint branch from 65a876c to 2bc47d8 Compare April 5, 2024 15:23
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 83.09859% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 28.36%. Comparing base (fcbc011) to head (cb271df).
Report is 10 commits behind head on dev.

Files Patch % Lines
editoast/src/views/v2/train_schedule.rs 83.09% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7119      +/-   ##
============================================
- Coverage     28.47%   28.36%   -0.12%     
+ Complexity     2268     2247      -21     
============================================
  Files          1094     1095       +1     
  Lines        136916   138010    +1094     
  Branches       2770     2761       -9     
============================================
+ Hits          38991    39146     +155     
- Misses        96322    97264     +942     
+ Partials       1603     1600       -3     
Flag Coverage Δ
core 78.97% <ø> (-0.46%) ⬇️
editoast 72.89% <83.09%> (-2.30%) ⬇️
front 8.97% <ø> (-0.01%) ⬇️
gateway 2.45% <ø> (ø)
railjson_generator 87.15% <ø> (ø)
tests 83.98% <ø> (+0.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@younesschrifi younesschrifi force-pushed the yci/add-editoast-simulation-summary-endpoint branch 6 times, most recently from cb271df to 3945a1a Compare April 9, 2024 11:12
@younesschrifi younesschrifi requested a review from a team as a code owner April 9, 2024 11:12
@younesschrifi younesschrifi force-pushed the yci/add-editoast-simulation-summary-endpoint branch from 3945a1a to 4e7e023 Compare April 9, 2024 11:14
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to update osrdEditoastApi.ts I believe. This PR seems like a work in progress, do not hesitate to create it as a Draft to make it obvious that this not need a review right now. Because maintainers do receive notifications for these PR.

editoast/src/views/v2/train_schedule.rs Outdated Show resolved Hide resolved
@younesschrifi younesschrifi force-pushed the yci/add-editoast-simulation-summary-endpoint branch from 4e7e023 to 4dfd816 Compare April 11, 2024 07:43
@younesschrifi younesschrifi marked this pull request as draft April 11, 2024 07:44
@younesschrifi younesschrifi force-pushed the yci/add-editoast-simulation-summary-endpoint branch 2 times, most recently from 438b8ec to 9bb4bc5 Compare April 11, 2024 07:58
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

editoast/src/views/v2/train_schedule.rs Outdated Show resolved Hide resolved
editoast/src/views/v2/train_schedule.rs Outdated Show resolved Hide resolved
@younesschrifi younesschrifi self-assigned this Apr 11, 2024
@younesschrifi younesschrifi force-pushed the yci/add-editoast-simulation-summary-endpoint branch from 9bb4bc5 to d7a4bd7 Compare April 11, 2024 07:59
@younesschrifi younesschrifi marked this pull request as ready for review April 11, 2024 08:01
@younesschrifi younesschrifi force-pushed the yci/add-editoast-simulation-summary-endpoint branch 2 times, most recently from 52f17e8 to 0e3b230 Compare April 11, 2024 08:50
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor comments, nothing is blocking.

Thank you for all the comments too (even on private functions, it might be useful)... although maybe too many comments 😜 (yes, sorry, I like comments but with frugality).

editoast/src/views/v2/train_schedule.rs Show resolved Hide resolved
editoast/src/views/v2/train_schedule.rs Show resolved Hide resolved
editoast/src/views/v2/train_schedule.rs Outdated Show resolved Hide resolved
editoast/src/views/v2/train_schedule.rs Outdated Show resolved Hide resolved
editoast/src/views/v2/train_schedule.rs Outdated Show resolved Hide resolved
editoast/src/views/v2/train_schedule.rs Outdated Show resolved Hide resolved
editoast/src/views/v2/train_schedule.rs Show resolved Hide resolved
@younesschrifi younesschrifi force-pushed the yci/add-editoast-simulation-summary-endpoint branch from 0e3b230 to a14db8f Compare April 11, 2024 09:13
@younesschrifi younesschrifi force-pushed the yci/add-editoast-simulation-summary-endpoint branch from a14db8f to 1e42fce Compare April 11, 2024 09:28
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@younesschrifi younesschrifi added this pull request to the merge queue Apr 11, 2024
@younesschrifi younesschrifi removed this pull request from the merge queue due to a manual request Apr 11, 2024
@younesschrifi younesschrifi added this pull request to the merge queue Apr 11, 2024
Merged via the queue into dev with commit 8f43d76 Apr 11, 2024
17 checks passed
@younesschrifi younesschrifi deleted the yci/add-editoast-simulation-summary-endpoint branch April 11, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS2: Add editoast simulation summary endpoint
4 participants