-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yci/add editoast simulation summary endpoint #7119
Yci/add editoast simulation summary endpoint #7119
Conversation
65a876c
to
2bc47d8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #7119 +/- ##
============================================
- Coverage 28.47% 28.36% -0.12%
+ Complexity 2268 2247 -21
============================================
Files 1094 1095 +1
Lines 136916 138010 +1094
Branches 2770 2761 -9
============================================
+ Hits 38991 39146 +155
- Misses 96322 97264 +942
+ Partials 1603 1600 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cb271df
to
3945a1a
Compare
3945a1a
to
4e7e023
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll also need to update osrdEditoastApi.ts
I believe. This PR seems like a work in progress, do not hesitate to create it as a Draft to make it obvious that this not need a review right now. Because maintainers do receive notifications for these PR.
4e7e023
to
4dfd816
Compare
438b8ec
to
9bb4bc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9bb4bc5
to
d7a4bd7
Compare
52f17e8
to
0e3b230
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor comments, nothing is blocking.
Thank you for all the comments too (even on private functions, it might be useful)... although maybe too many comments 😜 (yes, sorry, I like comments but with frugality).
0e3b230
to
a14db8f
Compare
a14db8f
to
1e42fce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
close #6857