Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: refactor infra tests part 2 #7626

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Jun 5, 2024

part of #6980

@hamz2a hamz2a requested a review from a team as a code owner June 5, 2024 14:14
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.43%. Comparing base (e97a8a1) to head (0ba5a53).
Report is 22 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7626      +/-   ##
============================================
- Coverage     29.00%   28.43%   -0.58%     
- Complexity     2021     2028       +7     
============================================
  Files          1207     1242      +35     
  Lines        147365   153096    +5731     
  Branches       2909     3004      +95     
============================================
+ Hits          42747    43530     +783     
- Misses       102903   107778    +4875     
- Partials       1715     1788      +73     
Flag Coverage Δ
core 75.01% <ø> (+0.01%) ⬆️
editoast 71.84% <100.00%> (-0.09%) ⬇️
front 9.84% <ø> (+0.13%) ⬆️
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.54% <ø> (+0.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

editoast/src/infra_cache/operation/update.rs Outdated Show resolved Hide resolved
@hamz2a hamz2a force-pushed the hai/editoast-refactor-infra-tests-part-2 branch from 352e9d4 to 0ba5a53 Compare June 5, 2024 15:50
@hamz2a hamz2a added this pull request to the merge queue Jun 5, 2024
Merged via the queue into dev with commit 5c6be9e Jun 5, 2024
17 checks passed
@hamz2a hamz2a deleted the hai/editoast-refactor-infra-tests-part-2 branch June 5, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants