fix: Rider has build issues with .NET 9 #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximilien-noal
added
bugfix
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
maximilien-noal
force-pushed
the
fix/rider_builds_with_dotnet8
branch
2 times, most recently
from
1dfccdb to
680fddc
Compare
kevinferrare
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.NET 9 prevents Rider (at least on some machines) from building Spice86. Those machines include @kevinferrare 's machine, and it is a blocking issue and not acceptable.
The problem is documented on the JetBrains' side of things, but in the meantime going back to .NET 8 is an easy fix.
Testing
Try to build the solution with Rider. It should build with .NET 8.
'dotnet build' works either way, the issue is with .NET 9 support from JetBrains Rider itself.