Sync master branches #750
Sync master branches #750
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/Spice86.Core/Emulator/OperatingSystem/Structures/DosDiskTransferArea.cs
Outdated
Show resolved
Hide resolved
src/Spice86.Core/Emulator/OperatingSystem/Structures/DosDiskTransferArea.cs
Outdated
Show resolved
Hide resolved
maximilien-noal
added
reverse engineering
| int bufferLength = _buffer.Length; | ||
| for (int i = _writeIndex; i < _writeIndex + bufferLength; i++) { | ||
| int bufferIndex = i % bufferLength; | ||
| sb.AppendLine(_buffer[bufferIndex]?.ToString()); |
Check notice
Code scanning / CodeQL
Redundant ToString() call Note
| @@ -46,6 +45,8 @@ public class ExecutionFlowRecorder { | |||
| private readonly HashSet<uint> _instructionsEncountered = new(200000); | |||
| private readonly HashSet<uint> _executableCodeAreasEncountered = new(200000); | |||
|
|
|||
| private readonly CircularBuffer<string> _callStack = new(20); | |||
There was a problem hiding this comment.
This is already recorded by FunctionHandler which already provides a method to dump the call stack as string.
DumpCallStack
Isnt it what you need?
There was a problem hiding this comment.
Not quite. Comparing the output:
.....1834:7259 -> 1834:6182
.....1834:7313 -> 1834:6253
......1834:626F -> 1834:623E
.......1834:624A -> 1000:13C8
........1000:13D0 -> 1000:2E10
.........1000:2E27 -> 1000:2E2D
..........1000:2E62 -> 1000:27A9
......1834:6281 -> 1000:15F2
......1834:62A6 -> 1834:623E
.......1834:624A -> 1000:13C8
........1000:13D0 -> 1000:2E10
.........1000:2E27 -> 1000:2E2D
..........1000:2E62 -> 1000:27A9
....4C9B:028D -> 1834:3EB7
.....1834:3EC4 -> 1834:39D0
.....1834:3ED8 -> 1000:06D9
......1000:070F -> 1000:3544
....4C9B:0297 -> 4C9B:047E
...2083:03D2 -> 38A2:002F
vs
- unknown_38A2_002F_38A4F expected to return to address 2083:03D7
- interrupt_handler_0x3F_36BC_04F6_370B6 expected to return to address 38AD:0027
- unknown_38AD_0025_38AF5 expected to return to address 4C9B:003F
- unknown_4C9B_0030_4C9E0 expected to return to address 4C9B:0197
- interrupt_handler_0x3F_36BC_04F6_370B6 expected to return to address 38A2:002C
- unknown_38A2_002A_38A4A expected to return to address 2083:03CB
- unknown_2083_038C_20BBC expected to return to address 2083:0E4E
- interrupt_handler_0x3F_36BC_04F6_370B6 expected to return to address 382F:0002
- interrupt_handler_0x3F_36BC_04F6_370B6 expected to return to address 396F:0022
- unknown_396F_0020_39710 expected to return to address 4B5A:057C
- unknown_382F_005C_3834C expected to return to address 2083:0E33
- unknown_2083_0E15_21645 expected to return to address 1000:015D
- unknown_1000_3298_13298 expected to return to address 1000:0260
- unknown_1000_0220_10220 expected to return to address 1000:014C
- entry_1000_0000_10000 expected to return to address
I did name my helper wrong. It's not the call stack, but the last 20 executes function calls.
It helps a lot in figuring out how you got to a certain location in the code. Especially to figure out where the value for an argument in the current function comes from, since it's often the return value of a previous function call.
I'm also totally fine with just keeping these in my branch if they're not of general use.
There was a problem hiding this comment.
I'm OK with merging all of this. Once this _callStack object is renamed to (for example) _lastTwentyExecutedFunctionCalls ?
Description of Changes
A bunch of changes I had lying around my branch for ages.
Rationale behind Changes
It's mostly small tweaks to make my life easier during reverse engineering of Krondor and debugging of Spice86.
Feel free to comment on stuff that should definitly not go into Spice86 and I'll keep those in my own branch.
Otherwise it'd be nice if we all work from mostly the same core codebase.
Suggested Testing Steps
Run games, do debugging, try out stuff.