Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Internal debugger memory and execution breakpoints #874

Merged
merged 39 commits into from
Nov 23, 2024

Conversation

maximilien-noal
Copy link
Member

@maximilien-noal maximilien-noal commented Oct 1, 2024

Introduces Breakpoint support in the DISASM view (Execution Breakpoints), Memory view (Memory Access/Read/Write breakpoint), and in a dedicated Breakpoints view.

Breakpoints created via the internal debugger can't go out of sync with the GDB support, since the internal debugger is not accessible if the GDB server is present.

image

image

@maximilien-noal maximilien-noal force-pushed the feature/debugger_start_breakpoint branch from c9ea476 to 3e58dd8 Compare October 1, 2024 21:15
@maximilien-noal maximilien-noal marked this pull request as ready for review October 1, 2024 21:16
@maximilien-noal maximilien-noal self-assigned this Oct 11, 2024
@maximilien-noal maximilien-noal added reverse engineering Related to reverse enginneering (features, APIs, ...) UI UI work labels Oct 11, 2024
@maximilien-noal maximilien-noal removed the request for review from kevinferrare October 11, 2024 22:02
@maximilien-noal maximilien-noal force-pushed the feature/debugger_start_breakpoint branch from 8036772 to 83e877b Compare October 12, 2024 07:47
@maximilien-noal maximilien-noal marked this pull request as draft October 27, 2024 11:37
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal maximilien-noal force-pushed the feature/debugger_start_breakpoint branch from 656b713 to 260db55 Compare October 27, 2024 19:42
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal maximilien-noal force-pushed the feature/debugger_start_breakpoint branch 2 times, most recently from d00623f to ca1c38b Compare October 30, 2024 22:52
src/Spice86/ViewModels/MemoryViewModel.cs Fixed Show fixed Hide fixed
src/Spice86/ViewModels/MemoryViewModel.cs Dismissed Show dismissed Hide dismissed
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal maximilien-noal force-pushed the feature/debugger_start_breakpoint branch from ca1c38b to 4b23df7 Compare November 3, 2024 10:27
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal maximilien-noal force-pushed the feature/debugger_start_breakpoint branch from c4c51f7 to 6095a47 Compare November 11, 2024 19:22
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal maximilien-noal force-pushed the feature/debugger_start_breakpoint branch from 9749ed6 to d6979de Compare November 11, 2024 19:57
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal maximilien-noal force-pushed the feature/debugger_start_breakpoint branch 2 times, most recently from 8d8e039 to 53f368d Compare November 17, 2024 18:02
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal maximilien-noal force-pushed the feature/debugger_start_breakpoint branch from 53f368d to 0a24469 Compare November 17, 2024 18:02
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal maximilien-noal merged commit c90047d into master Nov 23, 2024
5 checks passed
@maximilien-noal maximilien-noal deleted the feature/debugger_start_breakpoint branch November 23, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reverse engineering Related to reverse enginneering (features, APIs, ...) UI UI work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants