Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync minor additions #906

Merged
merged 35 commits into from
Oct 27, 2024
Merged

Sync minor additions #906

merged 35 commits into from
Oct 27, 2024

Conversation

JorisVanEijden
Copy link
Contributor

Description of Changes

  • Add Krondor image cause it looks nice.
  • Add argument fetcher and DoOnMemoryRead breakpoint helper
  • Add verbose logging for when VGA switches to a different lbokc of memory to display.

Rationale behind Changes

Just some tiny things I added along the way and that are annoying to redo when testing Spice86 MRs

Suggested Testing Steps

...

maximilien-noal and others added 30 commits August 31, 2024 14:45
@maximilien-noal
feature: UI icons for some elements
0049a85 
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal
DebugWindow: Put Pause/Continue on top (UI)
8eb1a8b 
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal
refactor: simpler disassemblyView toolbar layout
3c048a1 
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal
features: (UI) StatusBar and GroupBox
b32b4cc 
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal
feature: Debugger tabs hotkeys
7a10961 
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal
feature: Left-aligned tabs (debugger UI)
9b291a6 
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal
feature: minimum windows sizes (UI)
e2ff2dc 
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal
feature: more appropriate icons
221909b 
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal
fix: Memory edit dialog was transparent
2d3695a 
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal
feature: copy instruction context menu
17ca313 
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal
refactor: no start offset for DISASM view
cdf1aca 
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal
more informations copied to clipboard
e074605 
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal
feature: memory search UI
1bc6ef1 
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal
feature: Internal Debugger Step Into
7c3668b 
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal
fix: disable PIC if paused
dc575bc 
This makes the internal debugger step into more reliable.

Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal
refactor: disasm view updates
270786a 
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal
refactor: reliable and sane StepInto
0a62d2e 
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal
chore: code formatting
a04c710
@maximilien-noal
chore: removed unused using
ef4b3b0 
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal
docs: completed Stack documentation
3ba5960 
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal
docs: corrected Stack documentation (Discard)
e7984b1 
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal
chore: upgraded Avalonia. tests SDK
7235286 
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@JorisVanEijden
Merge remote-tracking branch 'upstream/feature/fully_featured_debugge…
49d761b 
…r_ui'

# Conflicts:
#	src/Spice86/Spice86.csproj
@maximilien-noal @JorisVanEijden
Refact: stack string on several lines
01cb563 
Co-authored-by: Joris van Eijden <joris.vaneijden@gmail.com>
@maximilien-noal @JorisVanEijden
Typo
c402e1c 
Co-authored-by: Joris van Eijden <joris.vaneijden@gmail.com>
@maximilien-noal
docs: properly inheritdocs
597dee3 
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal
fix: UI don't trigger breakpoints on mem reads
d49ab13 
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@JorisVanEijden
Merge remote-tracking branch 'upstream/feature/fully_featured_debugge…
f33a450 
…r_ui'
@maximilien-noal
fix: Set IsPaused from the UI thread
d101078 
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@JorisVanEijden
Merge remote-tracking branch 'upstream/feature/fully_featured_debugge…
d798d04 
…r_ui'
maximilien-noal
maximilien-noal requested changes Oct 27, 2024
View reviewed changes
Copy link
Member

@maximilien-noal maximilien-noal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The only change I'd request is to return something instead of void + out parameters.

src/Spice86.Core/Emulator/ReverseEngineer/ArgumentFetcher.cs Show resolved Hide resolved
@maximilien-noal maximilien-noal added the reverse engineering Related to reverse enginneering (features, APIs, ...) label Oct 27, 2024
@JorisVanEijden JorisVanEijden merged commit 3617210 into OpenRakis:master Oct 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinferrare kevinferrare kevinferrare approved these changes

@maximilien-noal maximilien-noal maximilien-noal approved these changes

Assignees

@JorisVanEijden JorisVanEijden

Labels
reverse engineering Related to reverse enginneering (features, APIs, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JorisVanEijden @maximilien-noal @kevinferrare