Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: CA1859, CA1860 warnings fix #947

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Conversation

maximilien-noal
Copy link
Member

@maximilien-noal maximilien-noal commented Nov 23, 2024

Changes private signatures and private variables to use concrete types instead of interfaces when possible.

Some lines replace the usage of LINQ with direct collection properties, such as the Any extension method begin replaced with List.Count

Doesn't measurably improves performance, but makes VS shut up about it.

@maximilien-noal maximilien-noal merged commit bffc80f into master Nov 23, 2024
4 of 5 checks passed
@maximilien-noal maximilien-noal deleted the fix/performance branch December 29, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants