Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/debugger QoL #948

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Feat/debugger QoL #948

merged 2 commits into from
Nov 27, 2024

Conversation

maximilien-noal
Copy link
Member

@maximilien-noal maximilien-noal commented Nov 26, 2024

Description of Changes

Introduces keyboard shortcuts and tooltips everywhere, or almost everywhere. Including the Breakpoints view. Now, a breakpoint can be enabled/disabled with a simple keyboard shortcut.

Makes Step Into 'go to CS:IP' only if needed. Meaning we can see what we already executed, unless CS:IP is out of viewable range. In this case we refresh the disassembly, and the instruction at CS:IP becomes the first line of the disassembly listing again.

Rationale behind Changes

Makes the debugger behave more like the one found in Visual Studio.

Makes Step into more readable.

Suggested Testing Steps

Already tested. But tests and suggestions are welcome!

Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Copy link
Contributor

@JorisVanEijden JorisVanEijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the unused using this looks fine.

Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
@maximilien-noal maximilien-noal merged commit 763e681 into master Nov 27, 2024
4 checks passed
@maximilien-noal maximilien-noal deleted the feat/debugger_QoL branch November 27, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI UI work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants