Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show OVAL graph for notapplicable rules #241

Open
jan-cerny opened this issue Jul 12, 2024 · 0 comments · May be fixed by #245
Open

Do not show OVAL graph for notapplicable rules #241

jan-cerny opened this issue Jul 12, 2024 · 0 comments · May be fixed by #245

Comments

@jan-cerny
Copy link
Member

Is your feature request related to a problem? Please describe.
If an XCCDF rule has been evaluated as "notapplicable", the OVAL definition obviously can't be evaluated and its result is always "not evaluated". In this situation people are interested in the CPE OVAL details and they aren't interested in OVAL details at all. From the UX view, people are used to first watch the position where the OVAL graph for the OVAL definition is shown and they suddenly become very confused by the "not evaluated" result. Therefore, I propose to not display OVAL graph in "notapplicable" rules. This will move the user's eyes to the CPE OVAL details and their OVAL graphs.

Describe the solution you'd like
If a rule result is notapplicable, do not show OVAL details and OVAL graph of the OVAL definition. Optionally, add an explanation in the place where they are normally shown.

Describe alternatives you've considered
No

Additional context
No
jan-cerny added a commit to jan-cerny/oscap-report that referenced this issue Aug 2, 2024
@jan-cerny
Do not show OVAL details for notapplicable rules
6707a87 
With this patch, we won't show OVAL details for notapplicable rules.
The reason is that if a rule is notapplicable the OVAL isn't evaluated
at all. Also, the users are interested only in the CPE OVAL.

Fixes: OpenSCAP#241
@jan-cerny jan-cerny linked a pull request Aug 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not show OVAL details for notapplicable rules jan-cerny/oscap-report
1 participant
@jan-cerny