Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for subdomain checking in aliases and socket aliases #3458

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidtrihy-genesys
Copy link
Contributor

Summary
Adds support for subdomains in aliases and socket aliases

Details
New feature related to this issue #1466

When defining sockets or aliases we can mark them with subdomain so that when check_self is called it will match when there the host to check is subdomain of the alias, definition of the socket and alias as so

socket = udp:127.0.0.1:5060 as my.subdomain.com subdomain

or

alias = udp:my.subdomain.com:5060 subdomain

If either are set up this way then when check_self is called for example in the TM topology_hiding then if the request domain is something like resource.my.subdomain.com or different.resource.my.subdomain.com it will match the alias but also a deliberate design decision to allow my.subdomain.com to match too.

Solution
A flag is added, when the subdomain|SUBDOMAIN flag is on the socket or alias this allows it to match addresses that match that alias subdomain while preserving strict matching when the flag is not set

Compatibility
The flag is a new flag so existing config where the subdomain flag is not on the alias or socket will behave like it already does without this change, it's backwards compatible

Closing issues
closes #1466

@bogdan-iancu bogdan-iancu self-assigned this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants