Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in installation.rst #32

Merged
merged 2 commits into from
Nov 1, 2019
Merged

Conversation

mayeshh
Copy link

@mayeshh mayeshh commented Oct 31, 2019

There is a broken link in the installation.rst doc file. Assuming I am pointing to the correct website, I have adjusted the file accordingly.

Practicing PRs (pretty insignificant suggestion).

@tritemio
Copy link

tritemio commented Nov 1, 2019

Nothing is insignificant. Everybody needs to start from somewhere.

PR is good. As you can see tests fail, but is not your fault. I encourage to go and look at the log of the failing tests. The environment used by the CI tests is created fresh every time. Most packages are not pinned to a version, and in this case the latest matplotlib version breaks the tests due to removal of normpdf, as reported in #30. The fail is at import time, before the tests start running. This is the most common cause of test breakage, especially for trivial PR.

So, I am merging this.

You can monitor the building of the docs (see logs and errors) at this RTD page:

https://readthedocs.org/projects/fretbursts/

Docs are built for the latest release (called stable on RTD) and for the latest master (latest on RTD). Also to build docs we recreate and env and install FRETBursts, so we may have the same failure, unless matplotlib is pinned. I'll now merge to see what happens.

@tritemio tritemio merged commit c9efe1a into OpenSMFS:master Nov 1, 2019
@mayeshh mayeshh deleted the fix_link branch November 1, 2019 16:20
@mayeshh
Copy link
Author

mayeshh commented Nov 1, 2019

Thank you for the explanation. I saw that there might be a conflict but did not understand why.

Leaving the fork open to work on a solution for the removal of normpdf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants