Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pyjq dependencies from our GH Actions #560

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

kneckinator
Copy link
Contributor

@kneckinator kneckinator commented Sep 2, 2024

Why is this change needed?

Removing the temporarily added dependencies to reduce the runtime of our GH Actions.
These were added as openg2p-vci was using them. Now that openg2p-vci has moved to jq, we no longer need to install the dependencies required to install pyjq.

See OpenG2P/openg2p-vci#11

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.59%. Comparing base (41d1c72) to head (7f7e68e).
Report is 2 commits behind head on 17.0.

Additional details and impacted files
@@           Coverage Diff           @@
##             17.0     #560   +/-   ##
=======================================
  Coverage   73.59%   73.59%           
=======================================
  Files         559      559           
  Lines       14056    14056           
  Branches     1792     1792           
=======================================
  Hits        10345    10345           
  Misses       3394     3394           
  Partials      317      317           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…elated dependencies

Removing the temporarily added dependencies reduces the runtime of our GH Actions.

See OpenG2P/openg2p-vci#11
@kneckinator kneckinator force-pushed the ken/remove-pyjq-dependencies-from-gh-action branch from 591f154 to 7f7e68e Compare September 3, 2024 00:59
Copy link

sonarqubecloud bot commented Sep 3, 2024

@kneckinator kneckinator merged commit 38a3b55 into 17.0 Sep 3, 2024
9 of 10 checks passed
@kneckinator kneckinator deleted the ken/remove-pyjq-dependencies-from-gh-action branch September 3, 2024 04:27
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants