Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Add absence concept in attendance server #671

Open
wants to merge 2 commits into
base: 17.0
Choose a base branch
from

Conversation

reichie020212
Copy link
Member

Why is this change needed?

To add absence concept in the attendance module

How was the change implemented?

Added new field named attendance_category in the attendance.list then added this new field in UI and APIs.

New unit tests

None

Unit tests executed by the author

None

Related links

https://github.com/OpenSPP/openspp-ph-dswd-4p-modules/issues/2

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 12.24490% with 43 lines in your changes missing coverage. Please review.

Project coverage is 72.66%. Comparing base (ca5926e) to head (5371960).

Files with missing lines Patch % Lines
spp_attendance/controllers/controllers.py 2.32% 42 Missing ⚠️
spp_attendance/models/attendance_subscriber.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #671      +/-   ##
==========================================
- Coverage   72.73%   72.66%   -0.07%     
==========================================
  Files         667      667              
  Lines       17259    17281      +22     
  Branches     2195     2199       +4     
==========================================
+ Hits        12553    12558       +5     
- Misses       4305     4322      +17     
  Partials      401      401              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Dec 6, 2024

@kneckinator
Copy link
Contributor

There is also the branch spp_attendance_test_branch. Does this extend this branch and if so, should a PR to merge spp_attendance_test_branch into spp_attendance be created and applied first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants