-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
641 fix gender deletion #680
base: 17.0
Are you sure you want to change the base?
Conversation
…modules into 641-fix-gender-deletion
@emjay0921 please check the issue with the test. The compatibility issue is causing the error. |
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 17.0 #680 +/- ##
==========================================
+ Coverage 72.73% 72.91% +0.17%
==========================================
Files 667 659 -8
Lines 17259 16933 -326
Branches 2195 2164 -31
==========================================
- Hits 12553 12346 -207
+ Misses 4305 4185 -120
- Partials 401 402 +1 ☔ View full report in Codecov by Sentry. |
Why is this change needed?
To fix the validation when deleting a gender.
How was the change implemented?
Modified the
gender
field type to many2one and enable the restriction ofondelete
.New unit tests
Unit tests executed by the author
How to test manually
spp_farmer_registry_demo
orspp_mis_demo
.Related links
#641