This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
Add additional nodes to long ways during rendering #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drawtext literal string safe
…accesses." This reverts commit 6a0695a.
… with the data. I am not sure if there is supposed to be any empty role attributes.
…ulo on the incrementor seems wrong from the outset, but there may have been some intention behind it...)
…verwrited, rather than extend the addez9s HashMap)
…open a .osm file with that changeset)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Apologies for not submitting this sooner. I've been a bit distracted with other work and forgot about it for a while.)
Issue: Sections of tiles are sometimes missing on the public OpenSeaMap servers. This is a known problem, and happens because the nodes in some ways are distanced too far apart. Tiles are rendered based on nodes found within those tiles, so ways will sometimes intersect tiles that do not get flagged for rendering.
Solution: During the search step, add additional nodes to ways between nodes that are further away from each other than a certain distance.
Dependencies: Check build.xml for Jsearch. I have added dom2 as a dependency. It's needed because it now parses the z9 files individually to add the nodes.
I have successfully rendered the entire OpenSeaMap chart using this. I haven't spotted anything anomalous yet, and previously missing sections that I knew of appear to have been rendered correctly.
By my count, 244 extra z10, 1053 extra z11, and 4346 extra z12 .osm files were generated from the version of the database I used for testing.
I had to fix a couple of issues not directly related to this feature to render the entire map:
87248d0
71d1e7e
So those commits are not strictly speaking a part of the 'additional nodes' feature.
In terms of lines of code, it's a fairly substantial change. Though I feel pretty confident at this point that it should work, I have 'only' done a full rendering so far, and have not yet gotten around to running the rendering pipeline continuously. If at all possible, I'd still recommend running it on a test-setup, if such a thing exists, or at least backing up the public servers first.
Otherwise good luck with it (if you decide to use this), and I hope I didn't break anything important!
If you find any issues, I'll try to get it fixed as soon as possible, and any suggestions for improvement are of course welcome.