Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Codecov.io for coverage reporting #415

Merged
merged 4 commits into from
Jan 12, 2020

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Jan 12, 2020

Codacy shows some promise, and I'd still like to use it eventually because it does a whole lot of complex tracking for repo changes, and as noisy and alarmist as it can be, for the most part I like its static analysis reporting.

But, so far setting coverage reporting up hasn't worked, the reports just don't seem to be getting there. meanwhile, setting the repo up at codecov.io was a total breeze, it Just Worked™ right away. So, let's funnel our reporting there for now. It's something, at least.

@ferdnyc ferdnyc added build Issues related to compiling or installing libopenshot and its dependencies code Source code cleanup, streamlining, or style tweaks labels Jan 12, 2020
@codecov-io
Copy link

codecov-io commented Jan 12, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@c83c098). Click here to learn what that means.
The diff coverage is 62.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #415   +/-   ##
==========================================
  Coverage           ?   42.37%           
==========================================
  Files              ?      129           
  Lines              ?    13276           
  Branches           ?        0           
==========================================
  Hits               ?     5626           
  Misses             ?     7650           
  Partials           ?        0
Impacted Files Coverage Δ
src/AudioReaderSource.cpp 0% <ø> (ø)
include/Clip.h 88.88% <ø> (ø)
src/EffectBase.cpp 16.12% <ø> (ø)
include/ClipBase.h 70.58% <ø> (ø)
include/Frame.h 100% <ø> (ø)
src/AudioBufferSource.cpp 0% <ø> (ø)
src/CacheMemory.cpp 87.09% <ø> (ø)
include/AudioReaderSource.h 0% <ø> (ø)
include/EffectBase.h 100% <ø> (ø)
src/CacheBase.cpp 68.75% <ø> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c83c098...6b16162. Read the comment docs.

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Jan 12, 2020

(See? Neato! Just needs some config tweaking...)

@@ -94,6 +80,23 @@ matrix:
- libavresample4
- libswresample3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because Travis plays favorites, tending to kick off matrix jobs in the order they're listed in the Travis configs, having our least critical (and quickest) build listed first was causing unnecessary delays even starting the later, more-critical ones.

Now, the Coverage build is listed first (because it requires extra processing time to generate and upload the report data), then the FFmpeg 4 build, followed by FFmpeg3 (GCC, Clang), and finally FFmpeg 2. Because nobody really cares that much anymore, whether we can still build libopenshot with FFmpeg 2.

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Jan 12, 2020

Merging, as that'll hopefully then make this commit the source of the baseline coverage report it keeps complaining about not having. (Also, it affects nothing but the repo metasources.)

@ferdnyc ferdnyc merged commit 49972b2 into OpenShot:develop Jan 12, 2020
@ferdnyc ferdnyc deleted the coverage-build branch January 12, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to compiling or installing libopenshot and its dependencies code Source code cleanup, streamlining, or style tweaks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants