CMake: Set minimum version to 3.12 #680
Conversation
Sync with upstream
Using an OBJECT library to link the bundled jsoncpp into a SHARED libopenshot fails with CMake versions up to 3.11.
ferdnyc
added
the
build
Codecov Report
@@ Coverage Diff @@
## develop #680 +/- ##
===========================================
+ Coverage 52.39% 53.67% +1.28%
===========================================
Files 151 130 -21
Lines 12365 10848 -1517
===========================================
- Hits 6479 5823 -656
+ Misses 5886 5025 -861
Continue to review full report at Codecov.
|
|
Urgh. Ubuntu Bionic is only at CMake 3.10, so this is breaking the PPA builds. (It was also breaking Xenial, which is running 3.5, but I just turned those off because that release is now past its support EOL date.) I guess I'll drop the minimum version requirement down to 3.10, though the build will still break if anyone running < 3.12 tries to use the bundled jsoncpp. (The PPA builds are using the system shared jsoncpp, so it's fine there.) |
(No wonder I couldn't find this PR, I opened it in my fork. Oy.)
Linking OBJECT libraries into SHARED targets (a trick to avoid recompilation of the bundled jsoncpp) means the build fails on all CMake versions through 3.11.
(Originally discussed via email. Solved on the project builders by @jonoomph, with an upgrade to CMake 3.20.2 on Linux. Windows was already on 3.20.1 following MSYS2 update, macOS is running 3.19.1.)
Technically CMake versions earlier than 3.12 will work if a precompiled system jsoncpp is used, but I'd rather only declare compatibility with versions for which we maintain unqualified support.