Support many new image formats with our FFmpegReader #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g empty packets in `GetPacketPTS`, and generating a duration and setting the has_single_image property.
jonoomph
commented
Oct 24, 2022
Codecov Report
@@ Coverage Diff @@
## develop #863 +/- ##
===========================================
- Coverage 50.56% 50.48% -0.09%
===========================================
Files 184 184
Lines 15988 15994 +6
===========================================
- Hits 8085 8074 -11
- Misses 7903 7920 +17
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support many new image formats with our FFmpegReader, by safely protecting empty packets in
GetPacketPTS, and generating a duration and correctly setting thehas_single_imageproperty.Essentially, this is a 1 frame video, but we want OpenShot to pretend it's a 60 minute long image.