Refactor FFmpegReader GetAVFrame (for AV1 & async decoding) #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Windows and trying to debug
…ader) - to support some types of multi-threaded video codecs (AV1)
…ws libopenshot docs
…er in FFmpegReader.
Codecov Report
@@ Coverage Diff @@
## develop #872 +/- ##
===========================================
+ Coverage 51.73% 51.88% +0.15%
===========================================
Files 187 187
Lines 16266 16328 +62
===========================================
+ Hits 8415 8472 +57
- Misses 7851 7856 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jonoomph
commented
Nov 15, 2022
jonoomph
commented
Nov 15, 2022
| @@ -977,7 +982,7 @@ std::shared_ptr<Frame> FFmpegReader::ReadStream(int64_t requested_frame) { | |||
|
|
|||
| // Video packet | |||
| if ((info.has_video && packet && packet->stream_index == videoStream) || | |||
| (info.has_video && !packet && packet_status.video_decoded < packet_status.video_read) || | |||
| (info.has_video && packet_status.video_decoded < packet_status.video_read) || | |||
There was a problem hiding this comment.
Call ProcessVideoPacket() anytime video_decoded < video_read... so we can potentially resend a packet if needed, or try and retrieve a processed AVFrame from the decoder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some decoders, for example
dav1d, process packets asynchronously and are multi-threaded. OpenShot was not correctly handling these async decoders, which resulted in dropping packets and freezing videos. This PR adds an AV1 decoding unit test as a verification, and correctly retries packets that fail to be sent to the decoder.For example, if a decoder can accept many packets before returning an AVFrame, it might also stop accepting new packets... until it's done processing the previous ones. In those cases, we need to halt getting the next packet, until we can successfully send the current packet.