Support for New Linux Build Server + glibc Wrapping #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonoomph
changed the title
jonoomph
commented
Nov 29, 2022
| @@ -65,6 +65,9 @@ int Fraction::GreatestCommonDenominator() { | |||
| void Fraction::Reduce() { | |||
| // Get the greatest common denominator | |||
| int GCD = GreatestCommonDenominator(); | |||
| if (GCD == 0) { | |||
There was a problem hiding this comment.
Prevent divide by zero error
Codecov Report
@@ Coverage Diff @@
## develop #878 +/- ##
===========================================
- Coverage 51.86% 51.85% -0.01%
===========================================
Files 187 187
Lines 16338 16339 +1
===========================================
Hits 8473 8473
- Misses 7865 7866 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: OpenShot/libopenshot-audio#146
Adding support for a new Linux build server, which has updated dependencies, but also a newer glibc version. Experimental support for wrapping glibc for older distros: https://github.com/wheybags/glibc_version_header