-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Names P2 #94
Display Names P2 #94
Conversation
if (LastName.ToLower() == "resident") | ||
return FirstName; | ||
else return $"{FirstName} {LastName}"; |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
if (IsNameDefault) | ||
return LegacyName; | ||
else return DisplayName; |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
{ | ||
OSDArray name = req["display_name"] as OSDArray; | ||
|
||
string oldName = name[0].AsString(); |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null Warning
name
this
if (d.Data.ContainsKey("DisplayName") && d.Data["DisplayName"] != null) | ||
u.DisplayName = d.Data["DisplayName"].ToString(); | ||
else | ||
u.DisplayName = string.Empty; |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
if (cmdparams.Length < 4) | ||
firstName = MainConsole.Instance.Prompt("First name"); | ||
else firstName = cmdparams[3]; |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
if (cmdparams.Length < 5) | ||
lastName = MainConsole.Instance.Prompt("Last name"); | ||
else lastName = cmdparams[4]; |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
if (cmdparams.Length < 6) | ||
displayName = MainConsole.Instance.Prompt("Display name"); | ||
else displayName = cmdparams[5]; |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
PR from Ruby's display names branch/repo