Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow meeting user restriction mode E for related user #1018

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

bastianjoel
Copy link
Member

In #972 there was a comment missed which requested to allow restriction mode to be accessible by the requesting user themselves.

#972 (comment)

@bastianjoel bastianjoel added this to the 4.2 milestone Sep 11, 2024
@reiterl reiterl assigned bastianjoel and unassigned reiterl Sep 11, 2024
@reiterl
Copy link
Member

reiterl commented Sep 12, 2024

A user with one meeting, which they is locked out, tries to log in.
=> In the operator:subscription the autoupdate service delivers one meeting_user object, but this doesn't include the 'meeting_id'. So the meeting_user object cannot be used in the code (e.g. to get the locked_out boolean).

@reiterl
Copy link
Member

reiterl commented Sep 12, 2024

@bastianjoel please look at it.

@bastianjoel
Copy link
Member Author

I think the best way to solve this is to add a new restriction mode to meetings E, for the field meeting_user_ids which is the same as B but allows locked out users.

On the other hand I think we don't necessarily need the meeting id in the client.

@bastianjoel
Copy link
Member Author

I solved this in the client.

@ostcar
Copy link
Member

ostcar commented Sep 24, 2024

@bastianjoel what is the status of this? Can this me merged or are you waiting for something?

@bastianjoel
Copy link
Member Author

I am currently waiting if OpenSlides/openslides-client#3815 needs additional requirements.

@bastianjoel bastianjoel merged commit 2168628 into OpenSlides:main Sep 25, 2024
2 checks passed
@bastianjoel bastianjoel deleted the 972-implement-comment branch September 25, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants