Reset cache on projector reset #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostcar
requested changes
Sep 20, 2023
There was a problem hiding this comment.
I think, you have to reset the cache AND the hotkeys.
It should not be a problem, if there are old Data in the hotkeys. When the cache is empty, then the hotkeys will be regenerated as soon, as the projection is calculated for the next time. But if the projection is never called after the reset, then the hotkeys will never be cleared. So I think it is better to clear them in the reset call.
m-schieder
approved these changes
Sep 20, 2023
peb-adr
added a commit
that referenced
this pull request
Oct 18, 2023
* commit '84c1bfc03a8ea54e9a0dec9f431d1d50e110da67': Bump github.com/klauspost/compress from 1.17.0 to 1.17.1 (#787) Bump github.com/alecthomas/kong from 0.8.0 to 0.8.1 (#785) Bump golang from 1.21.1-alpine to 1.21.2-alpine (#784) Bump golang.org/x/sys from 0.12.0 to 0.13.0 (#783) Bump golang.org/x/sync from 0.3.0 to 0.4.0 (#782) Add restrictor for import_preview (#781) Fix generic relation keys with fields that only exist on one field (#780) Bump leonsteinhaeuser/project-beta-automations from 2.1.0 to 2.2.1 (#778) Move profiler to internal route (#770) Reset cache on projector reset (#776) Bump github.com/klauspost/compress from 1.16.7 to 1.17.0 (#773) Bump golang.org/x/sys from 0.11.0 to 0.12.0 (#774)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #775