Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce speaker deletion logic to user.update and user.delete #1921

Merged
merged 9 commits into from
Oct 18, 2023
Merged

Introduce speaker deletion logic to user.update and user.delete #1921

merged 9 commits into from
Oct 18, 2023

Conversation

luisa-beerboom
Copy link
Member

Closes #1917

@luisa-beerboom luisa-beerboom added this to the 4.1 milestone Oct 5, 2023
@luisa-beerboom luisa-beerboom self-assigned this Oct 5, 2023
@luisa-beerboom luisa-beerboom marked this pull request as ready for review October 6, 2023 08:19
@reiterl reiterl mentioned this pull request Oct 16, 2023
Merged
r-peschke
r-peschke requested changes Oct 16, 2023
View reviewed changes
tests/system/action/user/test_update.py Show resolved Hide resolved
tests/system/action/user/test_update.py Outdated Show resolved Hide resolved
tests/system/action/user/test_update.py Outdated Show resolved Hide resolved
tests/system/action/user/test_update.py Outdated Show resolved Hide resolved
tests/system/action/user/test_delete.py Outdated Show resolved Hide resolved
openslides_backend/action/actions/user/conditional_speaker_cascade_mixin.py Outdated Show resolved Hide resolved
openslides_backend/action/actions/user/delete.py Outdated Show resolved Hide resolved
openslides_backend/action/actions/user/update.py Outdated Show resolved Hide resolved
tests/system/action/user/test_update.py Outdated Show resolved Hide resolved
openslides_backend/action/actions/user/conditional_speaker_cascade_mixin.py Outdated Show resolved Hide resolved
r-peschke
r-peschke approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@r-peschke r-peschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luisa-beerboom luisa-beerboom enabled auto-merge (squash) October 18, 2023 07:20
@luisa-beerboom luisa-beerboom merged commit b45eeb5 into OpenSlides:main Oct 18, 2023
4 checks passed
m-schieder added a commit that referenced this pull request Nov 1, 2023
@m-schieder
Merge main into stable/4.0.x. Update 20231101
377f01c 
* commit 'daba71c3e49e414f9455a542104a0e181b22d6d9':
  Fix speaker.delete and speaker.update for deleted users (#1935)
  Fix opentelemetry in backend (#1915)
  Allow strikthrough short tag (#1932)
  Introduce speaker deletion logic to user.update and user.delete (#1921)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-peschke r-peschke r-peschke approved these changes

Assignees

@r-peschke r-peschke

Labels
bug
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Don't delete past speakers upon user.delete
2 participants
@luisa-beerboom @r-peschke