Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CheckMediafileId presenter for anonymous user #2434

Merged

Conversation

bastianjoel
Copy link
Member

No description provided.

@bastianjoel bastianjoel self-assigned this May 21, 2024
@bastianjoel bastianjoel changed the base branch from main to feature/anonymous-user May 21, 2024 14:04
@bastianjoel bastianjoel requested a review from rrenkert May 21, 2024 14:31
@bastianjoel bastianjoel assigned rrenkert and unassigned bastianjoel May 21, 2024
@r-peschke r-peschke self-requested a review May 22, 2024 10:38
@r-peschke r-peschke self-assigned this May 22, 2024
Copy link
Member

@r-peschke r-peschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some differences between the existing code and the description in https://github.com/OpenSlides/openslides-autoupdate-service/blob/main/internal/restrict/collection/mediafile.go. There are some paths to give an anonymous user access to mediafile, for instance with owner collection and mediafile with token or with disabled anonymous in meeting with mediafile.CAN_SEE and public mediafiles or some projector permissions.
But as a POC for anonymous user I'll approve it.

@r-peschke r-peschke assigned bastianjoel and unassigned r-peschke May 23, 2024
@bastianjoel bastianjoel merged commit 7fbc7ce into OpenSlides:feature/anonymous-user May 24, 2024
7 checks passed
@bastianjoel bastianjoel deleted the check-mediafile-anon branch May 24, 2024 07:22
@bastianjoel
Copy link
Member Author

There are some paths to give an anonymous user access to mediafile, for instance with owner collection and mediafile with token or with disabled anonymous in meeting with mediafile.CAN_SEE and public mediafiles or some projector permissions.

This has nothing to do with this PR. The changes made here are implemented the same in the restrictor.
Please open an issue if you think that there are other cases which need to be adjusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants