Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move moderator_note to LoS #2593

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

luisa-beerboom
Copy link
Member

@luisa-beerboom luisa-beerboom commented Sep 4, 2024

Closes #2592
Needs OpenSlides/openslides-meta#162

TODO:

  • migration!
  • fix agenda_item.update test

@luisa-beerboom luisa-beerboom added feature migration Introduces a new migration labels Sep 4, 2024
@luisa-beerboom luisa-beerboom added this to the 4.2 milestone Sep 4, 2024
@luisa-beerboom luisa-beerboom self-assigned this Sep 4, 2024
@luisa-beerboom luisa-beerboom changed the title Remove can_see from can_see_moderator_note Mobe moderator_note to LoS Sep 4, 2024
@luisa-beerboom luisa-beerboom changed the title Mobe moderator_note to LoS Move moderator_note to LoS Sep 5, 2024
@luisa-beerboom luisa-beerboom marked this pull request as ready for review September 5, 2024 09:58
@hjanott hjanott assigned luisa-beerboom and unassigned hjanott Sep 10, 2024
@m-schieder m-schieder self-requested a review September 23, 2024 13:01
Copy link
Member

@m-schieder m-schieder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[backendmanage] ERROR:openslides_backend.shared.handlers.base_handler:'NoneType' object is not iterable
[backendmanage] Traceback (most recent call last):
[backendmanage] File "/app/openslides_backend/migrations/migration_handler.py", line 102, in execute_migrate_command
[backendmanage] return handler.execute_command(command)
[backendmanage] File "/app/openslides_backend/migrations/migration_wrapper.py", line 76, in execute_command
[backendmanage] self.handler.finalize()
[backendmanage] File "/usr/local/lib/python3.10/site-packages/datastore/migrations/core/migration_handler.py", line 291, in finalize
[backendmanage] self.model_migrater.migrate()
[backendmanage] File "/usr/local/lib/python3.10/site-packages/datastore/migrations/core/migraters/model_migrater.py", line 29, in migrate
[backendmanage] events = migration.migrate(self.reader)
[backendmanage] File "/usr/local/lib/python3.10/site-packages/datastore/migrations/core/base_migrations/base_model_migration.py", line 16, in migrate
[backendmanage] return self.migrate_models()
[backendmanage] File "/app/openslides_backend/migrations/migrations/0056_move_moderator_notes.py", line 66, in migrate_models
[backendmanage] [
[backendmanage] File "/app/openslides_backend/migrations/migrations/0056_move_moderator_notes.py", line 97, in
[backendmanage] perm_substrings := [
[backendmanage] File "/app/openslides_backend/migrations/migrations/0056_move_moderator_notes.py", line 103, in
[backendmanage] if any(
[backendmanage] TypeError: 'NoneType' object is not iterable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature migration Introduces a new migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move moderator_notes to LoS
3 participants