-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anonymous user #3965
base: feature/anonymous-user
Are you sure you want to change the base?
Anonymous user #3965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Login page: Rewording of new button to 'Public access'
-
User account name for Anonymous user: Rename it to 'Public' - Group permission matrix > Group default name for anonymous user: rename it to 'Public'
- Group permission matrix > Positioning: The group should always be listed as the first group on the left after activation.
Settings > General:
-
Add a new heading 'System' above 'Closed Meeting'. The formatting should be the same as for 'Meeting information'
-
Place new setting below 'closed meeting'
-
Add a gray placeholder help text under new setting (Hint: will be changed during translations)
-
Global search: Didn't work currently. It should be possible to use Global search as public user. The accessible content is limited and defined by all public available data.
-
Dashboard > calender: Üublic user could see committee icon. -> Should not be visible
-
Chat / commentary field for motions: Public user group can't be selected. -> It should be possible to set the public group as 'Group with reading permission'. / In comparison: Writing should not be possible. (needs discussion)
Needs to be done in backend
I would prefer a backend solution here too
Works for me might be a problem with your setup |
Why not just add it when translating? |
Correct. Our stating setup does not have a running search service. I will talk to @m-schieder . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked it with @emanuelschuetze. We've found the following issues:
- User profil: language change doesn't work instantly. reload is needed
- Group name: Should be changed from 'Anonymous' to 'Public'. [Backend]
- Group position after activation: 'Public' group should be first in the group listing. [Backend]
- Dashboard > calender > meeting card: old committee icon position is not clickable -> whole card shoould be clickable
- Chat / commentary field for motions: Public user group can't be selected. -> It should be possible to set the public group as 'Group with reading permission'. - No writing permission. It should be a one-way-communication. / @rrenkert I have in mind we talked about it, but I can't remember if there were any hurdles to implement it. If yes, could you please write them for down?
- User name: Should be changed to 'Public'.
There are some problems with the dashboard being displayed after reload even with just one meeting public. |
Additional Change requests. Group Permission table:
Organization level - layout:
New filter in meeting list:
Scenario: logged in as public user
Meeting - archived and public:
|
Please open a backend issue for that. This will not be done here. |
This is still not an issue with this PR but with the setup.
Unrelated to this PR |
For documentation: OpenSlides/openslides-backend#2641 |
7a280c4
to
835fdc4
Compare
This is also not specific to anonymous user. I would prefer fixing this separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Visibility of icon in calendar: place icon the left side of the committee icon. Important: Public users should NOT see this icon --> Globe is currently visible in Public Access. Globe should not be visible. Also the position of the icon is wrong. The globe should be placed to left side of the committee icon, not left to the meeting name.
- Globe needs tool tip 'public'
- Add a new filter 'Status' in meeting list. The options should be 'is archived', 'is not archived', 'closed' and 'public'. -> The new filter that summarizes the different statuses of meetings is still missing. The 'Archived' filter is then obsolete as these options are integrated in the new 'Status' filter and can be deleted.
- Global search: didn't work currently -> global search in available content should be possible -> didn't work. I get error messages in console by searching something. (TypeError: Cannot read properties of null (reading 'message'))
Still a setup issue. You don't need to document this here. |
A second filter will be used. Option |
part of #3955
this PR assumes that(changed)active_meeting_ids
in organization gets restriction modeA
.Needs:
https://github.com/OpenSlides/openslides-media-service/tree/feature/anonymous-user