Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anonymous user #3965

Open
wants to merge 21 commits into
base: feature/anonymous-user
Choose a base branch
from

Conversation

bastianjoel
Copy link
Member

@bastianjoel bastianjoel commented Aug 1, 2024

part of #3955

this PR assumes that active_meeting_ids in organization gets restriction mode A. (changed)

Needs:
https://github.com/OpenSlides/openslides-media-service/tree/feature/anonymous-user

Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Login page: Rewording of new button to 'Public access'
  • User account name for Anonymous user: Rename it to 'Public'
  • Group permission matrix > Group default name for anonymous user: rename it to 'Public'
  • Group permission matrix > Positioning: The group should always be listed as the first group on the left after activation.

Settings > General:

  • Add a new heading 'System' above 'Closed Meeting'. The formatting should be the same as for 'Meeting information'

  • Place new setting below 'closed meeting'

  • Add a gray placeholder help text under new setting (Hint: will be changed during translations)

  • Global search: Didn't work currently. It should be possible to use Global search as public user. The accessible content is limited and defined by all public available data.

  • Dashboard > calender: Üublic user could see committee icon. -> Should not be visible

  • Chat / commentary field for motions: Public user group can't be selected. -> It should be possible to set the public group as 'Group with reading permission'. / In comparison: Writing should not be possible. (needs discussion)

@bastianjoel
Copy link
Member Author

bastianjoel commented Aug 27, 2024

Group permission matrix > Group default name for anonymous user: rename it to 'Public'

Needs to be done in backend

Group permission matrix > Positioning: The group should always be listed as the first group on the left after activation.

I would prefer a backend solution here too

Global search

Works for me might be a problem with your setup

@bastianjoel
Copy link
Member Author

bastianjoel commented Aug 27, 2024

Add a gray placeholder help text under new setting (Hint: will be changed during translations)

Why not just add it when translating?

@bastianjoel bastianjoel requested a review from MSoeb August 27, 2024 13:57
@bastianjoel bastianjoel assigned MSoeb and unassigned bastianjoel Aug 27, 2024
@rrenkert
Copy link
Collaborator

Global search

Works for me might be a problem with your setup

Correct. Our stating setup does not have a running search service. I will talk to @m-schieder .

Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked it with @emanuelschuetze. We've found the following issues:

  • User profil: language change doesn't work instantly. reload is needed
  • Group name: Should be changed from 'Anonymous' to 'Public'. [Backend]
  • Group position after activation: 'Public' group should be first in the group listing. [Backend]
  • Dashboard > calender > meeting card: old committee icon position is not clickable -> whole card shoould be clickable
  • Chat / commentary field for motions: Public user group can't be selected. -> It should be possible to set the public group as 'Group with reading permission'. - No writing permission. It should be a one-way-communication. / @rrenkert I have in mind we talked about it, but I can't remember if there were any hurdles to implement it. If yes, could you please write them for down?
  • User name: Should be changed to 'Public'.

@bastianjoel
Copy link
Member Author

There are some problems with the dashboard being displayed after reload even with just one meeting public.

@MSoeb
Copy link

MSoeb commented Sep 24, 2024

Additional Change requests.

Group Permission table:

  • As already described, changes are still missing in the group permissions table. Keywords group name and position.
  • If the setting for public user is deactivated, the group is still visible. -> Target: Group should not be visible after deactivating the setting for public user

Organization level - layout:

  • add new icon to public meetings. Icon = globe
  • Visibility of icon in calendar: place icon the left side of the committee icon. Important: Public users should NOT see this icon
  • Visibility of icon in meeting list: place icon left to meeting title (like closed meeting icon).
  • Visibility of icon in committee detail view: place symbol left to meeting title.

New filter in meeting list:

  • Add a new filter 'Status' in meeting list. The options should be 'is archived', 'is not archived', 'closed' and 'public'.

Scenario: logged in as public user

  • User profile: Change name to 'Public Access'. This should also be changed in the user profile if it is open, left to the light/dark mode button.
  • User profile: letters with dots are not fully visible. (example: Ö dots)
  • User profile: Imprint can't be opened
  • Global search: didn't work currently -> global search in available content should be possible
  • User is in meeting in the Elections menu and the right to view elections is revoked. An error message appears stating that the user should not be there. Clicking on the button takes you to the dashboard. -> Open question: How can we improve this? It is simply a strange behavior when a user is torn out of the meeting and has to open it again manually.

Meeting - archived and public:

  • Open question: Currently you can mark a meeting as archived and public. However, this means that the meeting is not publicly accessible. -> Is it possible and (technically) sensible for us to make a meeting archived and publicly accessible?

@bastianjoel
Copy link
Member Author

As already described, changes are still missing in the group permissions table. Keywords group name and position.

Please open a backend issue for that. This will not be done here.

@bastianjoel
Copy link
Member Author

bastianjoel commented Sep 24, 2024

Global search: didn't work currently -> global search in available content should be possible

This is still not an issue with this PR but with the setup.

User profile: letters with dots are not fully visible. (example: Ö dots)

Unrelated to this PR

@MSoeb
Copy link

MSoeb commented Sep 24, 2024

Please open a backend issue for that. This will not be done here.

For documentation: OpenSlides/openslides-backend#2641

@bastianjoel
Copy link
Member Author

User is in meeting in the Elections menu and the right to view elections is revoked

This is also not specific to anonymous user. I would prefer fixing this separately.

Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Visibility of icon in calendar: place icon the left side of the committee icon. Important: Public users should NOT see this icon --> Globe is currently visible in Public Access. Globe should not be visible. Also the position of the icon is wrong. The globe should be placed to left side of the committee icon, not left to the meeting name.
  • Globe needs tool tip 'public'
  • Add a new filter 'Status' in meeting list. The options should be 'is archived', 'is not archived', 'closed' and 'public'. -> The new filter that summarizes the different statuses of meetings is still missing. The 'Archived' filter is then obsolete as these options are integrated in the new 'Status' filter and can be deleted.
  • Global search: didn't work currently -> global search in available content should be possible -> didn't work. I get error messages in console by searching something. (TypeError: Cannot read properties of null (reading 'message'))

@MSoeb MSoeb assigned bastianjoel and unassigned emanuelschuetze and MSoeb Sep 27, 2024
@bastianjoel
Copy link
Member Author

Global search: didn't work currently -> global search in available content should be possible -> didn't work. I get error messages in console by searching something. (TypeError: Cannot read properties of null (reading 'message'))

Still a setup issue. You don't need to document this here.

@bastianjoel
Copy link
Member Author

Add a new filter 'Status' in meeting list. The options should be 'is archived', 'is not archived', 'closed' and 'public'. -> The new filter that summarizes the different statuses of meetings is still missing. The 'Archived' filter is then obsolete as these options are integrated in the new 'Status' filter and can be deleted.

A second filter will be used. Option is closed needs to be renamed to is not public

@bastianjoel bastianjoel assigned MSoeb and unassigned bastianjoel Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants