Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public organization mediafiles #4049

Merged
merged 53 commits into from
Sep 10, 2024

Conversation

Elblinator
Copy link
Member

@Elblinator Elblinator commented Aug 23, 2024

@Elblinator Elblinator added this to the 4.2 milestone Aug 23, 2024
@Elblinator Elblinator self-assigned this Aug 23, 2024
@Elblinator
Copy link
Member Author

Elblinator commented Aug 29, 2024

Still missing

  • the items in public folders need to be displayed on the meeting Level (currently only the root folder is displayed
  • canAccess() needs to be fixed in Order to exchange getViewModelUnsafe() with getViewModel() (mediafile-repository.service.ts -> getMeetingMediafile() -> getViewModelUnsafe -> canAccess() )
  • Editing of the Title should be disable on MeetingLevel (currently possible via edit dialog)
  • Deleting and moving of public files should be prohibited (currently possible with mutiselect and the actions in the breadcrumb
  • when moving a not public mediafile public folders should not be selectable
  • Publizising a mediafile (including folder) does not show the mediafile in a Meeting (info goes through via subscription though) -> display of publizised mediafiles needs to be fixed

Orga-Level:

  • The publizise dialog should change wording dependent on published_to_meetings_in_organization_id
  • Deleting public files should show the appropriate information (adta is used somewhere)
  • Moving a file into a public folder should show a warning that it will be public
  • Moving a file out of a public folder should show a warning that it won't be public anymore

@Elblinator Elblinator force-pushed the 3794-public-files branch 2 times, most recently from e899ee8 to 03c0ba3 Compare August 30, 2024 09:09
@bastianjoel bastianjoel self-assigned this Sep 2, 2024
@bastianjoel bastianjoel enabled auto-merge (squash) September 10, 2024 14:31
@bastianjoel bastianjoel merged commit 45646dc into OpenSlides:main Sep 10, 2024
2 checks passed
openslides-automation bot pushed a commit that referenced this pull request Sep 10, 2024
bastianjoel pushed a commit that referenced this pull request Sep 10, 2024
Co-authored-by: Elblinator <69210919+Elblinator@users.noreply.github.com>
@Elblinator Elblinator deleted the 3794-public-files branch September 27, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow orga-files/folders to be accessible in meetings
6 participants