Migrated netty to 4.x

[ooasis]

Hi,

I have submitted a pull request for netty migration on master branch. This is the request for "next" branch.

-thanks

[manolama]

Ah, hah, thanks! I was going to ask you to push against next but you beat me to it! I think we should push this in 1.8. 1.7 is almost done (one more bit of code I need) then we can cut it then add netty 4 to next. Would that work for you?

[manolama]

Also could you sign the contributors agreement please? https://docs.google.com/forms/d/1VVqKFTYNp3btgwXE51Zf9_Sfq66yZ4JbuEFrLlTD70E/viewform?embedded=true&formkey=dFNiOFROLXJBbFBmMkQtb1hNMWhUUnc6MQ

[ooasis]

Just submitted.

-thanks

From: Chris Larsen <notifications@git.luolix.topmailto:notifications@github.com>
Reply-To: OpenTSDB/asynchbase <reply@reply.git.luolix.topmailto:reply@reply.github.com>
Date: Wednesday, September 2, 2015 4:38 PM
To: OpenTSDB/asynchbase <asynchbase@noreply.git.luolix.topmailto:asynchbase@noreply.github.com>
Cc: Hang Sun <hsun@connexity.commailto:hsun@connexity.com>
Subject: Re: [asynchbase] Migrated netty to 4.x (#116)

Also could you sign the contributors agreement please? https://docs.google.com/forms/d/1VVqKFTYNp3btgwXE51Zf9_Sfq66yZ4JbuEFrLlTD70E/viewform?embedded=true&formkey=dFNiOFROLXJBbFBmMkQtb1hNMWhUUnc6MQ

Reply to this email directly or view it on GitHubhttps://github.com//pull/116#issuecomment-137274085.

[ooasis]

Whatever is better for the project works for me.

-thanks

From: Chris Larsen <notifications@git.luolix.topmailto:notifications@github.com>
Reply-To: OpenTSDB/asynchbase <reply@reply.git.luolix.topmailto:reply@reply.github.com>
Date: Wednesday, September 2, 2015 4:37 PM
To: OpenTSDB/asynchbase <asynchbase@noreply.git.luolix.topmailto:asynchbase@noreply.github.com>
Cc: Hang Sun <hsun@connexity.commailto:hsun@connexity.com>
Subject: Re: [asynchbase] Migrated netty to 4.x (#116)

Ah, hah, thanks! I was going to ask you to push against next but you beat me to it! I think we should push this in 1.8. 1.7 is almost done (one more bit of code I need) then we can cut it then add netty 4 to next. Would that work for you?

Reply to this email directly or view it on GitHubhttps://github.com//pull/116#issuecomment-137273952.

[ooasis]

The buffer implementation is now determined by following properties:
io.netty.noPreferDirect: false to prefer off-heap and true for heap allocation. Default to false
io.netty.allocator.type: default to pooled or unpooled on Android platform

[maugomez77]

Hi there, just to know if there are plans to migrate to netty 4, i guess on the 1.8 version, is that correct?

[ooasis]

Rebased to 1.8.0-SNAPSHOT

[stoyle]

Any progress on this? We're running into version conflicts now.

Anything I can do to help?

[stoyle]

I saw the branch has merge conflicts, so I tried to resolve them. Feel free to pull these in, if they help speed up the process:

stoyle@35fa206
stoyle@72c263c

One merge commit and one fix up commit, since the merge had logical conflicts.

I do have failing tests, reported by make, but the same tests seem to fail in official asynchbase/next branch.

I've signed the contributor agreement.

[samdvr]

Any progress on this PR? Is there something I can help push this task along?