change UnknownScannerException to NonRecoverableException #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manolama
reviewed
Jan 10, 2019
| @@ -29,7 +29,7 @@ | |||
| /** | |||
| * Exception thrown when we try to use an invalid or expired scanner ID. | |||
| */ | |||
| public final class UnknownScannerException extends RecoverableException | |||
There was a problem hiding this comment.
This would require some more work as the scanner would need to be reopened with a new UID. What does it solve for you?
sundeepsf
approved these changes
Feb 24, 2019
kai33
added a commit
to kai33/asynchbase
that referenced
this pull request
May 15, 2019
|
What additional steps need to be taken to get this merged? Anything I can do to help? |
|
I.e. if the underlying issue needs a different fix, or this PR is insufficient, can see what I can to help with that. |
kai33
added a commit
to kai33/asynchbase
that referenced
this pull request
Dec 13, 2019
* check in pom.xml * remove unnecessary plugins * remove unnecessary parent pom * apply patch OpenTSDB#202
|
why not this got merged after 2.5 years? |
|
the problem seems related to this change 061ec3, prior to this, will not retry UnknownScannerException. |
|
Is there any news about this fix concerning the scanner lease expiration bug detected using AsyncHbase 1.8.2 and HBase 2.x? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR of issue : #198