Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flickering ui on 2.2.0 #708

Closed
eswdd opened this issue Feb 25, 2016 · 6 comments
Closed

Flickering ui on 2.2.0 #708

eswdd opened this issue Feb 25, 2016 · 6 comments
Labels
Milestone

Comments

@eswdd
Copy link
Contributor

eswdd commented Feb 25, 2016

Hiya,

Got an odd bug when using Firefox on Windows on 2.2.0. Just open this link:

http://:4242/#start=2h-ago&m=sum:rate:tsd.rpc.received%7Btype=put,host=*%7D&o=&yrange=%5B0:%5D&key=top%20center&wxh=1800x1000&style=linespoint

What happens is that the page loads, updates the url, but with the tags the other way round, whereupon it loads again, rendering the tags the other way round, updates the url with the tags back the first way, updates the url..... ad infinitum.

Works fine in Chrome.

Cheers
Simon

@manolama manolama added the bug label Feb 28, 2016
@manolama
Copy link
Member

hmm, Do you know if it happens in 2.1.4 as well before the UI and tag handling changes? I'll take a look too.

@eswdd
Copy link
Contributor Author

eswdd commented Mar 14, 2016

Doesn't happen in 2.1.4.

@katameru
Copy link

+1, still a problem in 2.3

@johann8384 johann8384 added this to the v2.3.0 milestone Jul 6, 2016
@johann8384 johann8384 modified the milestones: v2.3.1, v2.3.0 Sep 6, 2016
@johann8384
Copy link
Member

I was able to re-create this in the NEXT branch with Firefox on OSX

@manolama
Copy link
Member

Ah, I can recreate it too. Ick. Working it now.

manolama added a commit to manolama/opentsdb that referenced this issue Sep 18, 2016
browsers can cause an infinite loop of loading. Now we sort after
parsing and before calling the API so it's determinant.
manolama added a commit that referenced this issue Sep 18, 2016
browsers can cause an infinite loop of loading. Now we sort after
parsing and before calling the API so it's determinant.

Signed-off-by: Chris Larsen <clarsen@yahoo-inc.com>
ollie314 added a commit to sis-cats/opentsdb that referenced this issue Sep 30, 2016
Fix OpenTSDB#708 where the sorting order of filters would change in some
johann8384 pushed a commit to johann8384/opentsdb that referenced this issue Dec 5, 2016
browsers can cause an infinite loop of loading. Now we sort after
parsing and before calling the API so it's determinant.

Signed-off-by: Chris Larsen <clarsen@yahoo-inc.com>
katameru pushed a commit to katameru/opentsdb that referenced this issue Jan 23, 2017
The implemented Comparable interface was very inconsistent, leading to randomly sorted lists.
@katameru
Copy link

This is still a problem in 2.3.0, I prepared a PR.

manolama pushed a commit to manolama/opentsdb that referenced this issue May 14, 2017
Fix OpenTSDB#708 by using better comparisons

The implemented Comparable interface was very inconsistent, leading to randomly sorted lists.
manolama pushed a commit that referenced this issue May 14, 2017
Fix #708 by using better comparisons

The implemented Comparable interface was very inconsistent, leading to randomly sorted lists.

Signed-off-by: Chris Larsen <clarsen@yahoo-inc.com>
manolama pushed a commit that referenced this issue May 14, 2017
Fix #708 by using better comparisons

The implemented Comparable interface was very inconsistent, leading to randomly sorted lists.

Signed-off-by: Chris Larsen <clarsen@yahoo-inc.com>
manolama pushed a commit that referenced this issue May 14, 2017
Fix #708 by using better comparisons

The implemented Comparable interface was very inconsistent, leading to randomly sorted lists.

Signed-off-by: Chris Larsen <clarsen@yahoo-inc.com>
dprime pushed a commit to longshotsyndicate/opentsdb that referenced this issue Feb 19, 2018
Fix OpenTSDB#708 by using better comparisons

The implemented Comparable interface was very inconsistent, leading to randomly sorted lists.

Signed-off-by: Chris Larsen <clarsen@yahoo-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants