Added Downsample normalize on week month and year #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
downsample normalize on week, month and year on non-UTC times using Java Calendar. It needs additional refinements, but it works, the resulting timestamp will be rounded off at the beginning of the week (7days), month (31days) or year (365days).
|
Cool, thanks for taking a stab at this! Could you do a couple of things:
|
| } | ||
|
|
||
| /** Returns timestamp aligned at the first day of month. */ | ||
| private long toFirstDayOfMonth(long timestamp) { |
There was a problem hiding this comment.
Move these to the DateTime class as we may want to share them
|
this is super useful. is this going to make it into 2.2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
downsample normalize on week, month and year on non-UTC times using Java Calendar.
It needs additional refinements, but it works, the resulting timestamp will be rounded off at the beginning of the week (7days), month (31days) or year (365days).