Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for valid counter in eos.py #376

Closed
cheynearista opened this issue Nov 20, 2017 · 1 comment
Closed

Check for valid counter in eos.py #376

cheynearista opened this issue Nov 20, 2017 · 1 comment
Assignees
@johann8384
Labels
bug
Milestone
1.3.3

Comments

@cheynearista
Copy link
Contributor

Need to check for valid counter key. In the case of vlan interface, we have no outUcastPkts field:

    "Vlan100": {
        "outUcastOctets": 708,
        "outMulticastOctets": 0,
        "inMulticastOctets": 0,
        "inOctets": 236,
        "inUcastOctets": 236,
        "outOctets": 708
    },

2017-11-20 09:08:22.874338 7148 tcollector 2 WARNING: eos.py: KeyError: 'outUcastPkts'
2017-11-20 09:08:36.113910 7148 tcollector 2 WARNING: collector eos.py terminated after 16 seconds with status cod
e 1, marking dead
tsuna pushed a commit that referenced this issue Dec 6, 2017
@cheynearista @tsuna
Check counter names exist before referencing. Fixes issue #376
942b119
@tsuna
Copy link
Member

tsuna commented Dec 6, 2017

Fixed by PR #377

@tsuna tsuna closed this as completed Dec 6, 2017
@johann8384 johann8384 added this to the 1.3.3 milestone Dec 5, 2018
@johann8384 johann8384 self-assigned this Dec 5, 2018
@johann8384 johann8384 added bug and removed enhancement labels Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johann8384 johann8384

Labels
bug
Projects
None yet
Milestone
1.3.3
Development

No branches or pull requests
3 participants
@tsuna @johann8384 @cheynearista