Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HadoopHttp library class doesn't recurse JSON fields, misses metrics #393

Closed
HariSekhon opened this issue Jul 20, 2018 · 1 comment · Fixed by #451
Closed

HadoopHttp library class doesn't recurse JSON fields, misses metrics #393

HariSekhon opened this issue Jul 20, 2018 · 1 comment · Fixed by #451

Comments

@HariSekhon
Copy link
Contributor

HariSekhon commented Jul 20, 2018

HadoopHttp library class doesn't recursely walk the JMX JSON properly for Hadoop / HBase and therefore doesn't extract all the metrics.

For example it doesn't extract LastGCInfo duration which is really important for monitoring GC Pause times (GCTimeMillis just doesn't cut it), since the 'value' of the field is json it fails the is_numeric() check from utils and skips it entirely:

  }, {
    "name" : "java.lang:type=GarbageCollector,name=G1 Young Generation",
    "modelerType" : "sun.management.GarbageCollectorImpl",
    "LastGcInfo" : {
      "GcThreadCount" : 24,
      "duration" : 265,

This will affect all the Hadoop and HBase plugins.

@HariSekhon HariSekhon changed the title HadoopHttp library class doesn't recurse, misses metrics HadoopHttp library class doesn't recurse JSON fields, misses metrics Jul 20, 2018
@HariSekhon
Copy link
Contributor Author

Looks like there is a patch pull request in #375 since last Oct but nobody has reviewed it.

johann8384 pushed a commit that referenced this issue Oct 28, 2020
split the jmx dict, get all metrics in sub-dict or sub-list

Fixes #393 #375
johann8384 added a commit that referenced this issue Oct 28, 2020
split the jmx dict, get all metrics in sub-dict or sub-list

Fixes #393 #375

Co-authored-by: johnson7788 <linghuchongxajh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant