New low level innodb metrics adjusted for mysql 5.5.17+ #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In MySQL 5.5, show engine innodb status changed output of RW locks from RW-shared spins 2602, OS waits 1301; RW-excl spins 77, OS waits 71 to RW-shared spins 344, rounds 10105, OS waits 334 RW-excl spins 5, rounds 399, OS waits 11 So modify code to look for these. Should be backward as the 5.1 regex format is untouched.
|
Has this been tested on both versions? |
|
Also, please ensure you have completed the CLA: http://opentsdb.net/contributing.html |
johann8384
added a commit
that referenced
this pull request
Feb 9, 2016
New low level innodb metrics adjusted for mysql 5.5.17+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MySQL 5.5.17 the format for innodb locks changed, so adjust code to be able to parse and collect both variants.