Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

last_datapoint = invocation time for collectors #309

Merged
merged 1 commit into from
Mar 30, 2016
Merged

last_datapoint = invocation time for collectors #309

merged 1 commit into from
Mar 30, 2016

Conversation

hbilar
Copy link
Contributor

@hbilar hbilar commented Mar 23, 2016

We have a collector that occasionally takes ages to run (40-50 seconds), and sometimes a lot longer (600+ seconds).

Killing after 600 seconds is fine, but we found that tcollector.py kept killing this collector in check_children() for newly spawned collectors, as the last_datapoint was too old on every invocation of check_children. Also, because it was being killed off all the time, the last_datapoint obviously never got updated after it hit the 600s limit the first time.

The fix around this (well, a fix that works for us, at least) is to set the last_datapoint of a collector to the time it was spawned, rather than when the object was first created (which could be ages ago).

@johann8384 johann8384 added the bug label Mar 30, 2016
@johann8384 johann8384 added this to the 1.3.1 milestone Mar 30, 2016
@johann8384 johann8384 self-assigned this Mar 30, 2016
@johann8384 johann8384 merged commit 230a4c5 into OpenTSDB:master Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants