fix elasticsearch sending booleans to opentsdb #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a generic bool-to-int convert in printmetric-function, so that any booleans sent for printing will be converted to an integer. Fixes an an issue where the metric `is_master` tried to send boolean values. If this is too generic, one could fix the specific `is_master` value in `_collect_server`-function, line [185](https://github.com/OpenTSDB/tcollector/blob/master/collectors/0/elasticsearch.py#L185) or [187](https://github.com/OpenTSDB/tcollector/blob/master/collectors/0/elasticsearch.py#L187) by explicitly changing only that to `int()`, but figured the generic approach is future-proof for any other metrics that might slip through as booleans.
|
@johann8384, you're on fire! Awesome work, thank you for your efforts! |
|
Thanks, I also took this as inspiration to fix this and another boolean
related fix that was done in another collector in the process_line function
so that tcollector itself will now handle False, false, True, and true as 0
and 1.
…On Thu, Sep 17, 2020, 11:36 AM Björn Zettergren ***@***.***> wrote:
@johann8384 <https://github.com/johann8384>, you're on fire! Awesome
work, thank you for your efforts!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#429 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABFYMNVLGTWRQHNKDG53F3SGIUGTANCNFSM4IQEJQRA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a generic bool-to-int convert in printmetric-function, so that any
booleans sent for printing will be converted to an integer.
Fixes an an issue where the metric
is_mastertried to send booleanvalues, causing opentsdb to log
java.lang.NumberFormatException: For input string: "False"If this is too generic, one could fix the specific
is_mastervalue in_collect_server-function, line 185 or 187 by explicitly changing onlythat to
int(), but figured the generic approach is future-proof for anyother metrics that might slip through as booleans.