Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Survey pubkey for CityMania client #37

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ldpl
Copy link

@ldpl ldpl commented Feb 19, 2024

@TrueBrain
Copy link
Member

Your fork announces itself as if it is a vanilla version. And that is problematic for the survey results.

The survey is meant to give a look what each fork/version combination is doing. By having a fork that announces itself as vanilla, it will end up on the same pile as vanilla results. In result, there will only be a single report, combining both. This is not helping either party, and a such, not something we are going to do.

If you want to participate in the survey, a solution for this problem has to be found first.

And just to avoid unrealistic expectations: I myself will not invest time in finding a solution for this. But not to worry, as everything is Open Source, you (or anyone else) can look around and see what a proper solution is, and implement that via Pull Requests!

@TrueBrain TrueBrain added the blocked This PR is currently blocked and should not be merged label Mar 1, 2024
@ldpl
Copy link
Author

ldpl commented Mar 1, 2024

I don't see an issue here, it announces itself as vanilla for the game networking code. Survey is a separate request so nothing stops me from sending another version there, no changes needed on the survey backend. Just let me know what field there are you looking at, I kind of assumed it would already separate forks based on their survey key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This PR is currently blocked and should not be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants