Validate reporter configuration #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clementbiron
approved these changes
Oct 18, 2023
MattiSG
reviewed
Oct 19, 2023
|
|
||
| ### Removed | ||
|
|
||
| - No longer define default configuration for `Reporter` module |
There was a problem hiding this comment.
I believe this was a breaking change: if the reuser relied on the default configuration and did not define theirs, the behaviour would be significantly altered as they would not have any issues updates anymore.
MattiSG
reviewed
Oct 19, 2023
Comment on lines
-57
to
-65
| "reporter": { | ||
| "githubIssues": { | ||
| "repositories": { | ||
| "declarations": "OpenTermsArchive/sandbox-declarations", | ||
| "versions": "OpenTermsArchive/sandbox-versions", | ||
| "snapshots": "OpenTermsArchive/sandbox-snapshots" | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
Shouldn't this be moved to config/test.json?
MattiSG
reviewed
Oct 19, 2023
Comment on lines
+135
to
+136
| ${this.repositories.versions ? `- ${latestVersionLink}` : ''} | ||
| ${this.repositories.snapshots ? `- ${latestSnapshotsLink}` : ''} |
There was a problem hiding this comment.
I am not sure I understand: what would it mean that only declarations are defined, but not snapshots nor versions? Do we want to support such behaviour? 🤔
There was a problem hiding this comment.
If MongoDB is used both for versions and snapshots, then we can't provide links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.