-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define an API to query records history #875
Merged
Merged
Changes from all commits
Commits
Show all changes
74 commits
Select commit
Hold shift + click to select a range
6b321b6
Make committer date always equal to author date
Ndpnt bafc612
Define commit message prefixes as constants
Ndpnt 85d26ce
Improve GitAdapter records iteration
Ndpnt 4dd31d7
Allow passing a promise for `content` to `record` function
Ndpnt 2a3e422
Handle asynchronous record content loading in recorder
Ndpnt a2f1f85
Update git adapter tests
Ndpnt 342ae17
Remove magic strings
Ndpnt 5e3fcf4
Add iterate function to MongoAdapter
Ndpnt 7bb2fac
Improve record function to MongoAdapter
Ndpnt 20ef5e0
Fix deprecation warning
Ndpnt cb8e026
Improve MongoAdapter tests
Ndpnt 2426753
Fix Recorder tests as content is now lazy loaded
Ndpnt d10df95
Fix Export tests as content is now lazy loaded
Ndpnt 1cdf524
Add getRecord function to GitAdapter
Ndpnt ff9373e
Add getRecords function to GitAdapter
Ndpnt f41f0d5
Add getRecord function to MongoAdapter
Ndpnt d08771a
Add getRecords function to MongoAdapter
Ndpnt 78f9929
Add count function to MongoAdapter
Ndpnt 9b784aa
Add count function to GitAdapter
Ndpnt a1ce9a0
Add history scripts logger module
Ndpnt 15b0252
Improve naming
Ndpnt 8098400
Better manage access to non-existent records
Ndpnt fcea33e
Simplify code
Ndpnt 8ee7ff5
Add history utils to import README
Ndpnt 2833919
Add script to update snapshots Ids references to full git hash
Ndpnt 01f3b76
Add script to migrate services
Ndpnt 7f0b9be
Significantly improvement of perf when getting commits
Ndpnt 55a0025
Name parameters for commits functions
Ndpnt 30ace5a
Remove obsolete code
Ndpnt 8d6d91e
Simplify code
Ndpnt b163bdc
Minor code style improvement
Ndpnt 785ed0f
Refactor storage adapters
Ndpnt 6d225e8
Rename `adapter` to `repository`
Ndpnt 270ede0
Update scripts
Ndpnt 4a0a4ca
Improve naming
Ndpnt b47a084
Minor doc update
Ndpnt 299e6c5
Ensure markdown extension is .md
Ndpnt a14715a
Create interface for repositories
Ndpnt 7bac4cc
Validate required params when instantiating Record
Ndpnt 7b56f29
Improve separation
Ndpnt db8eb0d
Improve repository API
Ndpnt e288af2
Make getCommit returns only one commit
Ndpnt d2f6c67
Improve function name
Ndpnt 5d823da
Improve returning null object
Ndpnt e1ac331
Update scripts
Ndpnt f728c66
Move repositories in recorder module
Ndpnt 8db2db2
Switch to a repository factory
Ndpnt 2be75cc
Improve recorder file structure
Ndpnt b26e88f
Throw an error when trying to access not loaded Record content
Ndpnt 43720a7
Add validation tests to Record
Ndpnt f0beb5f
Improve Record test readability
Ndpnt b182407
Add missing space
Ndpnt 9fc509c
Improve English
Ndpnt c1d4fcf
Remove useless parens
Ndpnt 1159c26
Follow subject convention in tests
Ndpnt 3e148da
Switch to static property and method
Ndpnt 3bf9f21
Improve variable name
Ndpnt 33c1813
Move variable declaration for clarity
Ndpnt 12aeaf2
Fix method name in script
Ndpnt 4f1c887
Rename variables for clarity
Ndpnt 1acc32e
Convert obsolete Classes to simple module
Ndpnt 3bd7d52
Improve phrasings
Ndpnt 7172c91
Remove obsolete parens
Ndpnt 2ee7c2a
Ensure optional methods behavior in RepositoryInterface
Ndpnt c19c6cc
Remove obsolete code
Ndpnt bd6a444
Assign all given params to a new Record
Ndpnt a665294
Do not filter Record fields before saving it in Mongo
Ndpnt f70e547
Switch method and property to public
Ndpnt f7a6880
Remove obsolete file
Ndpnt 4a1f2da
Remove redundant operations
Ndpnt f9c992e
Pass only required config
Ndpnt f95cf88
Fix main in package.json
Ndpnt 3e9593f
Improve variable name to avoid confusion
Ndpnt 69db45d
Improve naming
Ndpnt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need both
I
andi
?I see only one
interface.js
file in lower caseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the beginning my file was named
repositoryInterface.js
and I renamed it after.The rules I defined will be true for all interfaces so I support all naming.