Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support swift 5.9 with minimum 5.5 compatibility. #61

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

furby-tm
Copy link

Summarize your change.

Support Swift 5.9, visionOS 1.0+, and a minimum iOS version of 12.

Add a list of changes, and note any that might need special attention during review.

  • Created a new Swift Package manifest for backwards compatibility with Swift 5.5 and older.
  • Bumped the existing Swift Package manifest to support a minimum of Swift 5.9 (the minimum required for Swift/C++ interop), visionOS 1.0 and later, and a minimum iOS version of 12.

Reference associated tests.

  • All tests pass.

Signed-off-by: furby™ <devs@wabi.foundation>
@furby-tm
Copy link
Author

furby-tm commented Sep 27, 2024

Noted by @jchen9 - this is likely necessary to use the cross-platform (Linux included) CGRect type (reference).

This version bump is required to be able to begin deprecating the Objective-C bindings and support Swift/C++ interop, and making this Swift Package available for the Linux platform, immediately this change should now allow us to support visionOS.

@furby-tm
Copy link
Author

Screenshot 2024-09-27 at 2 50 03 AM

I've also targeted the visionOS platform, and verified this Swift Package builds successfully for that platform.

* note: this only applies to the OpenTimelineIO_CXX import,
  OpenTime_CXX has no issues importing as-is.

Signed-off-by: furby™ <devs@wabi.foundation>
Signed-off-by: furby™ <devs@wabi.foundation>
* This target does not yet support the fuller OpenTimelineIO API.
* This target should work cross-platform (on Linux, macOS, & Windows),
  since it uses Swift/C++ interop, without any objc dependencies.

Signed-off-by: furby™ <devs@wabi.foundation>
Signed-off-by: furby™ <devs@wabi.foundation>
Signed-off-by: furby™ <devs@wabi.foundation>
Signed-off-by: furby™ <devs@wabi.foundation>
Signed-off-by: furby™ <devs@wabi.foundation>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants