task/4190-implement-regression-test-for-otanalytics-cli-using-test-data #485

briemla · 2024-03-15T14:06:22Z

OP#4190
OP#4146

randy-seng

Lookds good! Just two comments that I have~

tests/conftest.py

tests/regression_otanalytics.py

…alytics-cli-using-test-data

briemla added 4 commits March 14, 2024 11:42

Move code to be reused in regression test

9b0eb4f

Suppress future warnings

d6bc4b8

Add regression test

7928b00

Add github workflow to run regression test

bd7a121

briemla requested a review from randy-seng March 15, 2024 14:06

briemla assigned randy-seng Mar 15, 2024

briemla and others added 4 commits March 15, 2024 15:07

Rename workflow

c41f9b5

Temporarily activate workflow on pull request

aec067b

Remove already defined constant

a3c020a

Do not run regression test workflow on every pull request

ee22390

randy-seng requested changes Mar 19, 2024

View reviewed changes

tests/conftest.py Outdated Show resolved Hide resolved

tests/regression_otanalytics.py Outdated Show resolved Hide resolved

briemla added 2 commits March 21, 2024 09:14

Moved code into separate module

09d032b

Remove duplicated code

3a1b4f2

briemla requested a review from randy-seng March 21, 2024 08:19

randy-seng previously approved these changes Mar 21, 2024

View reviewed changes

Merge branch 'main' into task/4190-implement-regression-test-for-otan…

732c076

…alytics-cli-using-test-data

randy-seng enabled auto-merge March 21, 2024 08:51

Fix import due to FlowParser having been moved to different location

67838dc

randy-seng dismissed their stale review via 67838dc March 21, 2024 08:58

randy-seng self-requested a review March 21, 2024 08:59

randy-seng approved these changes Mar 21, 2024

View reviewed changes

randy-seng merged commit 1d7e09d into main Mar 21, 2024
5 checks passed

randy-seng deleted the task/4190-implement-regression-test-for-otanalytics-cli-using-test-data branch March 21, 2024 09:01

Provide feedback