Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/5669 replace types all in mypy in pre commit configyaml #550

Merged
merged 18 commits into from
Sep 13, 2024
Merged

Bug/5669 replace types all in mypy in pre commit configyaml #550

merged 18 commits into from
Sep 13, 2024

Conversation

randy-seng
Copy link
Member

@randy-seng randy-seng commented Aug 20, 2024 •
edited
Loading

OP#5669

@randy-seng
Add script to update pre-commit type stubs
d55fbc1
@randy-seng
Update all dependencies
4276755
@randy-seng
Remove unused method
0c6f000
@randy-seng
Ensure Factory Method Always Receives a DataFrame
48d1595 
Adjust track flyweight factory method to guarantee it always receives a DataFrame.
Fix edge case where indexing a DataFrame with a single value might return a Series instead of a DataFrame.
@randy-seng
Format code
a2460fc
@randy-seng
Fix track export when using flyweights to create pandas DataFrame
97b39e0
@randy-seng
Convert to pandas index to list to resolve interface incompatibility …
0d2addd 
…with PandasTrackDataset
@randy-seng
Fix type hints
3822680
@randy-seng
Don't reuse geometry cache when filtering
c133b52
@randy-seng
Format code
233e2bb
@randy-seng
Fix performance drop when creating track flyweights
4e1e241
@randy-seng
Make code more readable
6e7cf32
@randy-seng
Add update precommit script as custom precommit hook
dbbeacc
@randy-seng randy-seng marked this pull request as ready for review August 20, 2024 15:27
@randy-seng randy-seng requested review from briemla and removed request for briemla August 20, 2024 15:33
@randy-seng randy-seng assigned randy-seng and unassigned briemla Aug 21, 2024
@randy-seng randy-seng removed the request for review from briemla August 21, 2024 07:23
@randy-seng randy-seng marked this pull request as draft August 21, 2024 07:23
@randy-seng randy-seng assigned briemla and unassigned randy-seng Aug 21, 2024
@randy-seng randy-seng marked this pull request as ready for review August 21, 2024 14:50
@randy-seng randy-seng removed the request for review from briemla August 27, 2024 11:04
briemla
briemla reviewed Sep 12, 2024
View reviewed changes
Copy link
Contributor

@briemla briemla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only two comments.

OTAnalytics/plugin_datastore/track_store.py Show resolved Hide resolved
OTAnalytics/plugin_parser/track_export.py Show resolved Hide resolved
@briemla briemla merged commit 7eb5958 into main Sep 13, 2024
6 checks passed
@briemla briemla deleted the bug/5669-replace-types-all-in-mypy-in-pre-commit-configyaml branch September 13, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briemla briemla briemla approved these changes

Assignees

@briemla briemla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randy-seng @briemla